Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Quick start docs and fix problem in docker/build.sh #830

Merged
merged 9 commits into from
Dec 5, 2022

Conversation

baiyangtx
Copy link
Contributor

@baiyangtx baiyangtx commented Dec 5, 2022

Why are the changes needed?

Add docs for quick start.

Brief change log

  • Add docs for the Quick start
  • Fix problem in build docker images in macos.

How was this patch tested?

  • Run test locally before making a pull request

Documentation

  • If yes, how is the feature documented? ( docs )

@github-actions github-actions bot added type:build type:docs Improvements or additions to documentation labels Dec 5, 2022
@baiyangtx baiyangtx added this to the Release 0.4.0 milestone Dec 5, 2022
@baiyangtx baiyangtx changed the title Docs quick start [Docs]: Quick start docs and fix problem in docker/build.sh Dec 5, 2022
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baiyangtx I left some comments.

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit 97162b0 into apache:master Dec 5, 2022
zhoujinsong added a commit that referenced this pull request May 31, 2023
* docs of quick start

* fix build script to get version

* fix dos2unix in Dockerfile

* change create-catalog.png

* handle comment by reviewer

* handle docker/build.sh can't run under MacOS

* Update site/docs/ch/quickstart/cdc-ingestion.md

replace "注" as note

Co-authored-by: ZhouJinsong <[email protected]>

* handle review comment

Co-authored-by: ZhouJinsong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:build type:docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants