-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Improve docs for relasing 0.7.0 #2931
Conversation
## Start AMS | ||
|
||
Enter the directory amoro-x.y.z and execute bin/ams.sh start to start AMS. | ||
|
||
```shell | ||
cd amoro-x.y.z | ||
bin/ams.sh start | ||
$ cd amoro-x.y.z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apache-amoro-x.y.z-bin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extracted folder name is still amoro-x.y.z
, reference:https://github.com/apache/amoro/blob/master/amoro-ams/dist/src/main/assemblies/bin.xml#L28
## Delete catalog | ||
When a user needs to delete a Catalog, they can go to the details page of the Catalog and click the Remove button at the bottom of the page to perform the deletion. | ||
|
||
{{< hint info >}} | ||
Before deleting a Catalog, AMS will verify whether there is metadata for tables under that Catalog. | ||
Before deleting a internal catalog, AMS will verify whether there is metadata for tables under that Catalog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an internal catalog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Co-authored-by: baiyangtx <[email protected]>
I have made some changes due to the review suggestion, PTAL. @tcodehuber @baiyangtx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why are the changes needed?
Fix some issues of docs for releasing 0.7.0
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation