deploy workflows: remove unnecessary step and set image tag to sha fo…

…r staging
aodn · Jan 23, 2024 · 1c6dcaa · 1c6dcaa
1 parent 4326677
commit 1c6dcaa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/.github/workflows/deploy-production.yml b/.github/workflows/deploy-production.yml
@@ -91,10 +91,6 @@ jobs:
           container-name: app
           image: ${{ vars.ECR_REGISTRY }}/${{ vars.ECR_REPOSITORY }}@${{ needs.build_push.outputs.image_digest }}
 
-      - name: Display Rendered Template
-        id: display-rendered-template
-        run: cat ${{ steps.update-api-image-tag.outputs.task-definition }} | jq -r
-
       - name: Deploy to Amazon ECS service
         uses: aws-actions/amazon-ecs-deploy-task-definition@v1
         with:

diff --git a/.github/workflows/deploy-staging.yml b/.github/workflows/deploy-staging.yml
@@ -31,7 +31,7 @@ jobs:
         with:
           context: .
           load: true
-          tags: ${{ vars.ECR_REPOSITORY }}:latest
+          tags: ${{ vars.ECR_REPOSITORY }}:${{ github.sha }}
 
       - name: Configure AWS Credentials
         uses: aws-actions/configure-aws-credentials@v4
@@ -53,7 +53,7 @@ jobs:
 #          Only building for AMD64 for now
 #          platforms: linux/amd64,linux/arm64
           push: true
-          tags: ${{ vars.ECR_REGISTRY }}/${{ vars.ECR_REPOSITORY }}:latest
+          tags: ${{ vars.ECR_REGISTRY }}/${{ vars.ECR_REPOSITORY }}:${{ github.sha }}
 
       - name: Push Image Digest to SSM
         run: |
@@ -92,10 +92,6 @@ jobs:
           container-name: app
           image: ${{ vars.ECR_REGISTRY }}/${{ vars.ECR_REPOSITORY }}@${{ needs.build_push.outputs.image_digest }}
 
-      - name: Display Rendered Template
-        id: display-rendered-template
-        run: cat ${{ steps.update-api-image-tag.outputs.task-definition }} | jq -r
-
       - name: Deploy to Amazon ECS service
         uses: aws-actions/amazon-ecs-deploy-task-definition@v1
         with: