Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hourly product to have a boolean include_non_qc option instead of qc_flags #100

Open
mhidas opened this issue Feb 24, 2020 · 0 comments
Open
Labels
enhancement New feature or request hourly_timeseries Issues relating to the hourly time series product
Milestone

Comments

@mhidas
Copy link
Contributor

mhidas commented Feb 24, 2020

This code can currently generate a product that includes any combination of qc flags. However, only a few of these combinations make sense. In practice, we're only going to use two of them:

  • (1, 2) - "good data" and "probably good data";
  • (0, 1, 2) - as above, plus "not quality controlled".

So instead of a flexible list of qc_flags included, we could just have a boolean include_non_qc argument. To avoid breaking changes, qc_flags can be left in as an optional override.

@mhidas mhidas added enhancement New feature or request hourly_timeseries Issues relating to the hourly time series product labels Feb 24, 2020
@mhidas mhidas added this to the v2.0 milestone Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hourly_timeseries Issues relating to the hourly time series product
Projects
None yet
Development

No branches or pull requests

1 participant