Create hourly product in moorings products pipeline #206
Conversation
(and update required version of aodntools)
mhidas
force-pushed
the
moorings_products_add_hourly
branch
from
b6d04f9 to
ecebe8c
Compare
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
=======================================
Coverage 88.84% 88.84%
=======================================
Files 44 44
Lines 2510 2510
Branches 420 420
=======================================
Hits 2230 2230
Misses 162 162
Partials 118 118Continue to review full report at Codecov.
|
|
|
||
| for qc_flags in self.product_qc_flags: | ||
|
|
||
| product_url, errors = hourly_aggregator(input_list, self.product_site_code, qc_flags, self.temp_dir) |
There was a problem hiding this comment.
I assume product_url is different given the qc_flags arguments!?
| @@ -54,19 +54,32 @@ def test_good_manifest(self, mock_webfeatureservice): | |||
| self.assertCountEqual(INPUT_FILE_COLLECTION.get_attribute_list('dest_path'), | |||
| handler.input_file_collection.get_attribute_list('dest_path') | |||
| ) | |||
| self.assertEqual(len(handler.file_collection), 5) | |||
|
|
|||
| self.assertEqual(len(handler.file_collection), 7) | |||
There was a problem hiding this comment.
why the 7 hardcoding? If it's because this class is only executed for a single test, them grab the number of file_collection as args.
There was a problem hiding this comment.
I also think the test_good_manifest is doing too much stuff - maybe some function refactoring !?
|
|
||
| self.assertEqual(len(handler.file_collection), 7) | ||
|
|
||
| # check new product files |
There was a problem hiding this comment.
this part can be a test function
|
|
||
| # check deletion of previous versions |
There was a problem hiding this comment.
this part can also be a separate one
There was a problem hiding this comment.
I leave some comments... The thing that poped out was that you can select nested list with QC flags to create different products but to know what will be the end result is hard.
Maybe a simple dictionary with names will help disambiguate at creation and when debugging.
|
Thanks @ocehugo . I have responded to your comments and made some changes. Please merge if you're happy with it. |
|
Thanks for the comments @ocehugo . I might address some of them later, but I'd like to merge this now. |
No description provided.