Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed NSW-DPE to NSW in the regex reading file names #392

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Changed NSW-DPE to NSW in the regex reading file names #392

merged 3 commits into from
Sep 4, 2024

Conversation

Yannick-Rousseau
Copy link
Contributor

No description provided.

@Yannick-Rousseau Yannick-Rousseau requested a review from bpasquer July 4, 2024 07:09
bpasquer
bpasquer previously requested changes Jul 6, 2024
View reviewed changes
Copy link
Contributor

@bpasquer bpasquer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "INSTITUTION_PATHNAME" also needs to be updated; otherwise, the path cannot be set.

@lbesnard
Copy link
Contributor

so we agree that the code on data-services reflect his change?

I don't really want to merge this PR right now.
what is the plan of action for existing files under https://thredds.aodn.org.au/thredds/catalog/Department_of_Planning_and_Environment-New_South_Wales/WAVE-BUOYS/REALTIME/WAVE-PARAMETERS/BENGELLO/2022/catalog.html

If we merge this PR, it means that we can't reprocess existing files if we're not planning on modifying/renaming them. Not ideas

@Yannick-Rousseau
Copy link
Contributor Author

To check with Bene when she is back.
My understanding is that the department fully wanted to change paths ('directories' names) as well, but this was the compromise.

@xhoenner xhoenner dismissed bpasquer’s stale review September 4, 2024 06:05

Requested change has been made

@xhoenner xhoenner requested review from bpasquer and removed request for lbesnard September 4, 2024 06:06
@xhoenner
Copy link
Contributor

xhoenner commented Sep 4, 2024

Should be good to go now @bpasquer

@xhoenner xhoenner merged commit 23baf1c into master Sep 4, 2024
0 of 3 checks passed
@xhoenner xhoenner deleted the NSW_department_change branch September 4, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpasquer bpasquer bpasquer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yannick-Rousseau @lbesnard @xhoenner @bpasquer