Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) Burst Average code failing with ALL bad qc flag variable - fix https://github.com/aodn/content/issues/453 #279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lbesnard
Copy link
Contributor

No description provided.

@lbesnard lbesnard requested a review from mhidas August 24, 2021 02:51
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #279 (45521ae) into master (d6fe7f1) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
+ Coverage   88.28%   88.44%   +0.15%     
==========================================
  Files          50       50              
  Lines        3295     3296       +1     
  Branches      542      542              
==========================================
+ Hits         2909     2915       +6     
+ Misses        243      239       -4     
+ Partials      143      142       -1     
Impacted Files Coverage Δ
aodndata/moorings/burst_average.py 89.95% <100.00%> (+2.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6fe7f1...45521ae. Read the comment docs.

Copy link
Contributor

@mhidas mhidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lbesnard . I haven't had a chance to test this. However, I'm not sure you're actually addressing the core problem here. The original issue said

The code ... crashes when it encounters a variable that has all its values (within a burst) flagged bad. It should just output a missing value for that burst.

From what I can see here, your change is to look for variables that have missing values (as opposed to flagged "Bad") for the entire dataset and removing them from entire variable from the output file... I don't think that's what we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants