4290 prefect pipeline #266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #266 +/- ##
==========================================
- Coverage 91.96% 90.39% -1.57%
==========================================
Files 39 41 +2
Lines 4082 4176 +94
Branches 590 485 -105
==========================================
+ Hits 3754 3775 +21
- Misses 265 334 +69
- Partials 63 67 +4
☔ View full report in Codecov by Sentry. |
digorgonzola
force-pushed
the
4290-prefect-pipeline
branch
from
e99a1f1 to
f666c6c
Compare
…re into 4290-prefect-pipeline
mhidas
reviewed
Oct 5, 2022
| @@ -0,0 +1,64 @@ | |||
| from urllib.parse import urlparse | |||
| import boto3 | |||
There was a problem hiding this comment.
Some functionality for handling objects on S3 is already implemented as an S3StorageBroker class that suports query, download, upload and delete operations. Could that be reused instead of duplicating the functionality here?
| """ Override HandlerBase""" | ||
|
|
||
| try: | ||
| self._file_checksum = self.etag |
There was a problem hiding this comment.
I can't see where this etag attribute is set?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These modify aodncore to allow for running of pipelines with Prefect and S3 buckets. The changes should not affect existing pipeline operations.