Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Celery specific references out of HandlerBase into the calli… #202

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Jan 13, 2020

…ng PipelineTask class to support non-Celery use cases

@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #202 (d36ec08) into master (0aa47d0) will increase coverage by 0.05%.
The diff coverage is 86.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   90.99%   91.05%   +0.05%     
==========================================
  Files          34       34              
  Lines        3511     3500      -11     
  Branches      432      432              
==========================================
- Hits         3195     3187       -8     
+ Misses        255      252       -3     
  Partials       61       61              
Impacted Files Coverage Δ
aodncore/pipeline/watch.py 64.81% <0.00%> (ø)
aodncore/pipeline/handlerbase.py 94.70% <90.47%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aa47d0...d36ec08. Read the comment docs.

@ghost ghost force-pushed the docker-entrypoint branch 3 times, most recently from 108d77b to 3227cae Compare January 14, 2020 23:57
…ng PipelineTask class to support non-Celery use cases
@ghost ghost force-pushed the docker-entrypoint branch from 3227cae to d36ec08 Compare December 7, 2020 00:43
@mhidas
Copy link
Contributor

mhidas commented Jan 19, 2021

@lwgordonimos I guess this one's just an idea for future development?

@ghost
Copy link
Author

ghost commented Jan 19, 2021

Yes that's right. It's very incomplete, and well out of date, but was just playing with getting celery references out of the core code. Not sure if there's anything really useful or salvageable from it to be honest...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant