Need to close resultset and statement objects used by JDBCDDB.java ju…

…st like the connection at the end.
aodn · Nov 6, 2017 · 46ed41f · 46ed41f
1 parent 0ec9dd3
commit 46ed41f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/Java/ddb.jar b/Java/ddb.jar
diff --git a/Java/src/org/imos/ddb/JDBCDDB.java b/Java/src/org/imos/ddb/JDBCDDB.java
@@ -100,6 +100,8 @@ public ArrayList<Object> executeQuery(
 					throws Exception {
 
 		Connection conn = null;
+		Statement stmt = null;
+		ResultSet rs = null;
 		ArrayList<Object> results = null;
 
 		try {
@@ -126,8 +128,6 @@ public ArrayList<Object> executeQuery(
 			}
 
 			//execute the query
-			Statement stmt = null;
-			ResultSet rs = null;
 			try {
 				stmt = conn.createStatement();
 				rs = stmt.executeQuery(query);
@@ -177,7 +177,13 @@ public ArrayList<Object> executeQuery(
 		}
 
 		//always close db connection
-		finally {try {conn.close();} catch (Exception e) {}}
+		finally {
+			try {
+				rs.close();
+				stmt.close();
+				conn.close();
+				} 
+			catch (Exception e) {}}
 
 		return results;
 	}