Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: cluster default to NONE instead of local if unset; add unittest to test no cluster #102

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

lbesnard
Copy link
Collaborator

No description provided.

@lbesnard lbesnard force-pushed the NoClusterUnittest branch 3 times, most recently from 9376182 to fac0876 Compare November 14, 2024 06:15
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.51163% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.52%. Comparing base (c4fa297) to head (277a68b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
..._optimised/test_generic_zarr_handler_no_cluster.py 96.34% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   76.64%   77.52%   +0.88%     
==========================================
  Files          24       25       +1     
  Lines        2556     2639      +83     
==========================================
+ Hits         1959     2046      +87     
+ Misses        597      593       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbesnard lbesnard merged commit 00ce565 into main Nov 14, 2024
7 checks passed
@lbesnard lbesnard deleted the NoClusterUnittest branch November 14, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants