Fix: MWA Select but No Connect Bug #1049
Conversation
| const adapter = useMemo( | ||
| () => adaptersWithMobileWalletAdapter.find((a) => a.name === walletName) ?? null, | ||
| [adaptersWithMobileWalletAdapter, walletName] |
There was a problem hiding this comment.
This is different to #960 and #1013 which change this to:
const adapter = useMemo(
() =>
adaptersWithMobileWalletAdapter.find((a) => a.name === walletName) ??
(adaptersWithMobileWalletAdapter.length === 1 && adaptersWithMobileWalletAdapter[0] === mobileWalletAdapter
? mobileWalletAdapter
: null),
[adaptersWithMobileWalletAdapter, walletName, mobileWalletAdapter]
);Do we not need that change any more?
It looks like that change was motivated by this comment: #960 (comment)
There was a problem hiding this comment.
Correct, we do not want this change. If it was added I would propose a new PR to remove it as it would bring back the bug we are trying to fix here 😅
This change was added originally to try to preserve the existing behavior with MWA in the (rare) case that MWA is the one and only adapter available on Mobile. But we are aiming to remove the existing behavior, since it causes the bug with react state leading to MWA being non-functional for mobile users.
There was a problem hiding this comment.
Its an edge case that will likely never happen anyways, MWA being the one and only adapter available. So between that and the fact that it can reintroduce the bug we are trying to fix, we think its better to remove this special treatment for MWA.
If at some point we decide to somehow change the react state handling in the UI layer to alleviate this issue caused by default selection of the adapter, we could then reintroduce special handling on MWA.
See this comment from, Jordan on the original pr.
There was a problem hiding this comment.
Got it, thanks! Glad we're finally getting this fixed!
This PR fixes an issue with MWA where the Solana Mobile wallet adapter gets stuck in a state that prevents the user from connecting to thier installed wallet. The issue is fully described with root cause and a video on our repo here.
This fix is nearly identical to the changes in #1013. All tests have been fixed to accommodate the new behavior. The #1013 PR should be closed in favor of this PR. Alternatively I can rebase my changes on that branch if you prefer @jordaaash.