v2.2: Removes background account hasher (backport of #4842) #4970
+32
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
brooksprumo
added
the
feature-gate
|
@Mergifyio rebase |
(cherry picked from commit 0844bbc)
✅ Branch has been successfully rebased |
brooksprumo
force-pushed
the
mergify/bp/v2.2/pr-4842
branch
from
59a82f7 to
4f4c95e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Once the accounts delta hash is removed (#4441), we no longer need the background account hasher.
Summary of Changes
Conditionally start the background hasher based on if the feature is enabled or not.
Justification to Backport
This PR is related to the feature gate for removing the accounts delta hash (#4441), which is in v2.2. When the feature gate is enabled, we need to stop sending accounts to the background thread to be hashed. More context here: #4842 (comment)
Feature gate issue: #4441
This is an automatic backport of pull request #4842 done by [Mergify](https://mergify.com).