Buffer pre-session tasks in BP unified scheduler #4949
Conversation
| // Skip registering for block production. Both the replay stage and PohRecorder | ||
| // don't support _concurrent block production_ at all. It's strongly assumed that | ||
| // block is produced in singleton way and it's actually desired, while ignoring the | ||
| // opportunity cost of (hopefully rare!) fork switching... |
There was a problem hiding this comment.
@steviez do we have data on how often we switch forks during leader slot? I'm not aware of any, but I don't believe it's super uncommon for it to happen?
There was a problem hiding this comment.
I don't think we have any data on hand, any metrics to easily measure this unfortunately
| } | ||
|
|
||
| pub fn is_preallocated(&self) -> bool { | ||
| self.bank.is_none() | ||
| } | ||
|
|
||
| pub fn mode(&self) -> SchedulingMode { | ||
| self.mode | ||
| } | ||
|
|
||
| pub fn bank(&self) -> &Arc<Bank> { |
There was a problem hiding this comment.
should this return Option similar to slot()?
| } | ||
|
|
||
| #[must_use] | ||
| pub fn schedule_or_buffer_task(&mut self, task: Task, force_buffering: bool) -> Option<Task> { |
There was a problem hiding this comment.
The force_buffering argument is a bit confusing to me.
The transaction is pushed into the scheduling structure regardless of whether it is blocked or unblocked, right?
The force_buffering seems to just return Some regardless if the transaction is blocked or not?
| (true, true) | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
I can't get to the line in review.
There's a series of comments on line 1332:
// High-level flow of new tasks:
// 1. the replay stage thread send a new task.
// 2. the scheduler thread accepts the task.
// 3. the scheduler thread dispatches the task after proper locking.
// 4. the handler thread processes the dispatched task.
// 5. the handler thread reply back to the scheduler thread as an executed task.
// 6. the scheduler thread post-processes the executed task.we should update this comment imo, but it doesn't necessarily have to be part of this PR - maybe not until the full implementation of production w/ all verification is in.
Problem
While #4533 introduced (really!) minimal integration between banking stage and unified scheduler, the unified scheduler still needs several improvements for optimal block production.
Summary of Changes
As a first step, support pre-session buffering.
extracted from #3946 (well, with large code cleaning up!)