Fix for issue rubenv#348: Getstring must not interpolate, interpolati…

…onContext is now a real subscope
anx-ckreuzberger · Aug 2, 2019 · 4b08e12 · 4b08e12
1 parent a999749
commit 4b08e12
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/dist/angular-gettext.js b/dist/angular-gettext.js
@@ -297,7 +297,6 @@ angular.module('gettext').factory('gettextCatalog', ["gettextPlurals", "gettextF
             string = this.getStringFormFor(this.currentLanguage, string, 1, context) ||
                      this.getStringFormFor(fallbackLanguage, string, 1, context) ||
                      prefixDebug(string);
-            string = scope ? $interpolate(string)(scope) : string;
             return addTranslatedMarkers(string);
         },
 

diff --git a/src/catalog.js b/src/catalog.js
@@ -245,7 +245,6 @@ angular.module('gettext').factory('gettextCatalog', function (gettextPlurals, ge
             string = this.getStringFormFor(this.currentLanguage, string, 1, context) ||
                      this.getStringFormFor(fallbackLanguage, string, 1, context) ||
                      prefixDebug(string);
-            string = scope ? $interpolate(string)(scope) : string;
             return addTranslatedMarkers(string);
         },
 

diff --git a/test/unit/catalog.js b/test/unit/catalog.js
@@ -101,20 +101,20 @@ describe("Catalog", function () {
         assert.equal(catalog.getPlural(2, "Bird", "Birds"), "[MISSING]: Birds");
     });
 
-    it("Can return an interpolated string", function () {
+    it("Can not interpolate strings", function () {
         var strings = { "Hello {{name}}!": "Hallo {{name}}!" };
         assert.deepEqual(catalog.strings, {});
         catalog.setCurrentLanguage("nl");
         catalog.setStrings("nl", strings);
-        assert.equal(catalog.getString("Hello {{name}}!", { name: "Andrew" }), "Hallo Andrew!");
+        assert.equal(catalog.getString("Hello {{name}}!", { name: "Andrew" }), "Hallo {{name}}!");
     });
 
-    it("Can return a pure interpolated string", function () {
+    it("Can not interpolate a pure string", function () {
         var strings = { "{{name}}": "{{name}}" };
         assert.deepEqual(catalog.strings, {});
         catalog.setCurrentLanguage("nl");
         catalog.setStrings("nl", strings);
-        assert.equal(catalog.getString("{{name}}", { name: "Andrew" }), "Andrew");
+        assert.equal(catalog.getString("{{name}}", { name: "Andrew" }), "{{name}}");
     });
 
     it("Can return an interpolated plural string", function () {