Skip to content

Commit

Permalink
[core] Rename external build file (ray-project#50642)
Browse files Browse the repository at this point in the history
Best practice for naming external BUILD file is `xxx.BUILD`, otherwise
vscode and plugin doesn't recognize it.

I follow what well-known projects do:
- grpc: https://github.com/grpc/grpc/tree/master/third_party
- tensorflow:
https://github.com/tensorflow/tensorflow/tree/master/third_party

Signed-off-by: dentiny <[email protected]>
  • Loading branch information
dentiny authored Feb 17, 2025
1 parent e88f6ca commit f4bfc55
Show file tree
Hide file tree
Showing 9 changed files with 7 additions and 7 deletions.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
14 changes: 7 additions & 7 deletions bazel/ray_deps_setup.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def auto_http_archive(

# auto appending ray project namespace prefix for 3rd party library reusing.
if build_file == True:
build_file = "@com_github_ray_project_ray//%s:%s" % ("bazel", "BUILD." + name)
build_file = "@com_github_ray_project_ray//%s:%s" % ("bazel", name + ".BUILD")

if urls == True:
prefer_url_over_mirrors = is_github
Expand Down Expand Up @@ -106,7 +106,7 @@ def ray_deps_setup():
# all of http/git_repository should add prefix for patches defined in ray directory.
auto_http_archive(
name = "com_github_antirez_redis",
build_file = "@com_github_ray_project_ray//bazel:BUILD.redis",
build_file = "@com_github_ray_project_ray//bazel:redis.BUILD",
patch_args = ["-p1"],
url = "https://github.com/redis/redis/archive/refs/tags/7.2.3.tar.gz",
sha256 = "afd656dbc18a886f9a1cc08a550bf5eb89de0d431e713eba3ae243391fb008a6",
Expand All @@ -118,7 +118,7 @@ def ray_deps_setup():

auto_http_archive(
name = "com_github_redis_hiredis",
build_file = "@com_github_ray_project_ray//bazel:BUILD.hiredis",
build_file = "@com_github_ray_project_ray//bazel:hiredis.BUILD",
url = "https://github.com/redis/hiredis/archive/60e5075d4ac77424809f855ba3e398df7aacefe8.tar.gz",
sha256 = "b6d6f799b7714d85316f9ebfb76a35a78744f42ea3b6774289d882d13a2f0383",
patches = [
Expand All @@ -128,7 +128,7 @@ def ray_deps_setup():

auto_http_archive(
name = "com_github_spdlog",
build_file = "@com_github_ray_project_ray//bazel:BUILD.spdlog",
build_file = "@com_github_ray_project_ray//bazel:spdlog.BUILD",
urls = ["https://github.com/gabime/spdlog/archive/v1.12.0.zip"],
sha256 = "6174bf8885287422a6c6a0312eb8a30e8d22bcfcee7c48a6d02d1835d7769232",
# spdlog rotation filename format conflict with ray, update the format.
Expand All @@ -140,7 +140,7 @@ def ray_deps_setup():

auto_http_archive(
name = "com_github_tporadowski_redis_bin",
build_file = "@com_github_ray_project_ray//bazel:BUILD.redis",
build_file = "@com_github_ray_project_ray//bazel:redis.BUILD",
strip_prefix = None,
url = "https://github.com/tporadowski/redis/releases/download/v5.0.9/Redis-x64-5.0.9.zip",
sha256 = "b09565b22b50c505a5faa86a7e40b6683afb22f3c17c5e6a5e35fc9b7c03f4c2",
Expand Down Expand Up @@ -341,7 +341,7 @@ def ray_deps_setup():
strip_prefix = "json-3.9.1",
urls = ["https://github.com/nlohmann/json/archive/v3.9.1.tar.gz"],
sha256 = "4cf0df69731494668bdd6460ed8cb269b68de9c19ad8c27abc24cd72605b2d5b",
build_file = "@com_github_ray_project_ray//bazel:BUILD.nlohmann_json",
build_file = "@com_github_ray_project_ray//bazel:nlohmann_json.BUILD",
)

auto_http_archive(
Expand All @@ -367,7 +367,7 @@ def ray_deps_setup():
http_archive(
name = "jemalloc",
urls = ["https://github.com/jemalloc/jemalloc/releases/download/5.3.0/jemalloc-5.3.0.tar.bz2"],
build_file = "@com_github_ray_project_ray//bazel:BUILD.jemalloc",
build_file = "@com_github_ray_project_ray//bazel:jemalloc.BUILD",
sha256 = "2db82d1e7119df3e71b7640219b6dfe84789bc0537983c3b7ac4f7189aecfeaa",
strip_prefix = "jemalloc-5.3.0",
)
File renamed without changes.
File renamed without changes.

0 comments on commit f4bfc55

Please sign in to comment.