clean up harmonic example and ignore files with 1_ext suffix #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Codecov Report
@@ Coverage Diff @@
## main #308 +/- ##
==========================================
+ Coverage 91.88% 91.89% +0.01%
==========================================
Files 47 47
Lines 2968 2987 +19
==========================================
+ Hits 2727 2745 +18
- Misses 241 242 +1
|
greschd
approved these changes
Jul 13, 2023
roosre
requested changes
Jul 13, 2023
PipKat
reviewed
Jul 19, 2023
PipKat
reviewed
Jul 19, 2023
PipKat
reviewed
Jul 19, 2023
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
roosre
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #306
Fix minor issues in harmonic example after discussion with Javier Vique.
Could not test with an actual workbench model because of #307, but the file structure looks correct.