Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace i.e with that is #490

Merged
merged 10 commits into from
Oct 4, 2023
Merged

Replace i.e with that is #490

merged 10 commits into from
Oct 4, 2023

Conversation

hegdeadithyak
Copy link
Contributor

@hegdeadithyak hegdeadithyak commented Oct 3, 2023 •
edited by samccann
Loading

Fixes #463

@github-actions github-actions bot added the needs_triage Needs a first human triage before being processed. label Oct 3, 2023
@hegdeadithyak hegdeadithyak changed the title Update automationhub.rst Update automationhub.rst and replace i.e with that is Oct 3, 2023
felixfontein
felixfontein reviewed Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

docs/docsite/rst/dev_guide/style_guide/index.rst Outdated Show resolved Hide resolved
docs/docsite/rst/dev_guide/style_guide/spelling_word_choice.rst Outdated Show resolved Hide resolved
docs/docsite/rst/os_guide/windows_usage.rst Outdated Show resolved Hide resolved
docs/docsite/rst/porting_guides/porting_guide_2.10.rst Outdated Show resolved Hide resolved
docs/docsite/rst/reference_appendices/automationhub.rst Outdated Show resolved Hide resolved
docs/docsite/rst/scenario_guides/guide_cloudstack.rst Outdated Show resolved Hide resolved
@hegdeadithyak hegdeadithyak changed the title Update automationhub.rst and replace i.e with that is Replace i.e with that is Oct 3, 2023
@hegdeadithyak
Copy link
Contributor Author

@felixfontein please check this!!

@hegdeadithyak
Copy link
Contributor Author

@felixfontein please check this!

@gotmax23 gotmax23 added the new_contributor This PR is the first contribution by a new community member. label Oct 3, 2023
@gotmax23
Copy link
Collaborator

gotmax23 commented Oct 3, 2023

Thanks for your Ansible docs contribution! We talk about Ansible documentation on matrix at #docs:ansible.im and on libera IRC at #ansible-docs if you ever want to join us and chat about the docs! We meet there on Tuesdays (see the Ansible calendar) and welcome additions to our weekly agenda items - scroll down to find the upcoming agenda and add a comment to put something new on that agenda.

@hegdeadithyak
Copy link
Contributor Author

@felixfontein Hey there ,this isn't merged yet,any issue? Please let me know.

@samccann
Copy link
Contributor

samccann commented Oct 3, 2023

@Adithya4720 hi! We appreciate your enthusiasm here but we can't guarantee immediate turnaround on PRs as they come in. Will take a look in a bit to see if there's more to change or not. Thanks.

@hegdeadithyak
Copy link
Contributor Author

@samccann Thanks!!

@samccann samccann removed the needs_triage Needs a first human triage before being processed. label Oct 4, 2023
@samccann samccann merged commit d866534 into ansible:devel Oct 4, 2023
@samccann
Copy link
Contributor

samccann commented Oct 4, 2023

Thanks @Adithya4720 for the Ansible docs fix and welcome to the Ansible project!

@samccann samccann added backport-2.15 Automatically create a backport for the stable-2.15 branch backport-2.14 Automatically create a backport for the stable-2.14 branch backport-2.13 Automatically create a backport for the stable-2.13 branch backport-2.16 Automatically create a backport for the stable-2.16 branch labels Oct 4, 2023
@patchback
Copy link

patchback bot commented Oct 4, 2023 •
edited
Loading

Backport to stable-2.15: 💔 cherry-picking failed — target branch does not exist

❌ Failed to fetch https://github.com/ansible/ansible-documentation.git

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Oct 4, 2023 •
edited
Loading

Backport to stable-2.14: 💔 cherry-picking failed — target branch does not exist

❌ Failed to fetch https://github.com/ansible/ansible-documentation.git

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Oct 4, 2023 •
edited
Loading

Backport to stable-2.13: 💔 cherry-picking failed — target branch does not exist

❌ Failed to fetch https://github.com/ansible/ansible-documentation.git

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Oct 4, 2023 •
edited
Loading

Backport to stable-2.16: 💔 cherry-picking failed — target branch does not exist

❌ Failed to fetch https://github.com/ansible/ansible-documentation.git

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@gotmax23 gotmax23 added backport-2.16 Automatically create a backport for the stable-2.16 branch and removed backport-2.16 Automatically create a backport for the stable-2.16 branch labels Oct 11, 2023
@patchback
Copy link

patchback bot commented Oct 11, 2023 •
edited
Loading

Backport to stable-2.16: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.16/d866534efba6b9879fb3371fb05374fb8568bbf2/pr-490

Backported as #564

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 11, 2023
@hegdeadithyak @patchback
Replace i.e with that is (#490)
41e1a43 
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit d866534)
@patchback patchback bot mentioned this pull request Oct 11, 2023
Merged
@gotmax23 gotmax23 added backport-2.15 Automatically create a backport for the stable-2.15 branch and removed backport-2.15 Automatically create a backport for the stable-2.15 branch labels Oct 11, 2023
@patchback
Copy link

patchback bot commented Oct 11, 2023 •
edited
Loading

Backport to stable-2.15: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.15/d866534efba6b9879fb3371fb05374fb8568bbf2/pr-490

Backported as #565

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 11, 2023
@hegdeadithyak @patchback
Replace i.e with that is (#490)
4e23ab7 
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit d866534)
@patchback patchback bot mentioned this pull request Oct 11, 2023
Merged
@gotmax23 gotmax23 added backport-2.14 Automatically create a backport for the stable-2.14 branch backport-2.13 Automatically create a backport for the stable-2.13 branch and removed backport-2.14 Automatically create a backport for the stable-2.14 branch backport-2.13 Automatically create a backport for the stable-2.13 branch labels Oct 12, 2023
@patchback
Copy link

patchback bot commented Oct 12, 2023 •
edited
Loading

Backport to stable-2.14: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.14/d866534efba6b9879fb3371fb05374fb8568bbf2/pr-490

Backported as #567

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Oct 12, 2023 •
edited
Loading

Backport to stable-2.13: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.13/d866534efba6b9879fb3371fb05374fb8568bbf2/pr-490

Backported as #566

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 12, 2023
@hegdeadithyak @patchback
Replace i.e with that is (#490)
35b4287 
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit d866534)
patchback bot pushed a commit that referenced this pull request Oct 12, 2023
@hegdeadithyak @patchback
Replace i.e with that is (#490)
c21b494 
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit d866534)
This was referenced Oct 12, 2023
Merged
Merged
samccann pushed a commit that referenced this pull request Oct 12, 2023
@patchback @hegdeadithyak
Replace i.e with that is (#490) (#564)
e378996 
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit d866534)

Co-authored-by: Adithya Hegde Kota <[email protected]>
samccann pushed a commit that referenced this pull request Oct 12, 2023
@patchback @hegdeadithyak
Replace i.e with that is (#490) (#565)
f375f9a 
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit d866534)

Co-authored-by: Adithya Hegde Kota <[email protected]>
samccann pushed a commit that referenced this pull request Oct 12, 2023
@patchback @hegdeadithyak
Replace i.e with that is (#490) (#566)
f7572a4 
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit d866534)

Co-authored-by: Adithya Hegde Kota <[email protected]>
samccann pushed a commit that referenced this pull request Oct 12, 2023
@patchback @hegdeadithyak
Replace i.e with that is (#490) (#567)
be18b94 
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit d866534)

Co-authored-by: Adithya Hegde Kota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
backport-2.13 Automatically create a backport for the stable-2.13 branch backport-2.14 Automatically create a backport for the stable-2.14 branch backport-2.15 Automatically create a backport for the stable-2.15 branch backport-2.16 Automatically create a backport for the stable-2.16 branch new_contributor This PR is the first contribution by a new community member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace i.e with that is
4 participants
@hegdeadithyak @gotmax23 @samccann @felixfontein