Replace apt-key with signed-by in Debian install instructions #106
Conversation
apt-key is deprecated for security reasons. See https://stackoverflow.com/a/71384057/11076036
|
The Ubuntu PPA now supports Debian 12, so I've added that to this PR as well. |
|
I'm not sure that b96aa62 makes sense when you're only using the value once, but I don't feel strongly. I'd like to get an ack from @dericcrago or one of the other maintainers of the PPA to make sure that the key is correct and that everything else is correct before merging. |
gotmax23
added
the
needs_triage
|
Thanks for your Ansible docs contribution! We talk about Ansible documentation on matrix at #docs:ansible.im and on libera IRC at #ansible-docs if you ever want to join us and chat about the docs! We meet there on Tuesdays (see the Ansible calendar) and welcome additions to our weekly agenda items - scroll down to find the upcoming agenda and add a comment to put something new on that agenda. |
gotmax23
added
the
new_contributor
Co-authored-by: Maxwell G <[email protected]>
You can find the key fingerprint on launchpad: https://launchpad.net/~ansible/+archive/ubuntu/ansible
My motivation for having a variable is laziness. If you are directly copy & pasting from the docs, you have to do sooo many back arrow presses to get your terminal cursor from the end to where UBUNTU_CODENAME is. With the variable you can really copy & paste the two long commands without having to edit them (even though it's one more line/paste). :) |
samccann
added
techreview
|
@gotmax23 - is this ready to merge or are you still waiting on a PPA person to review? |
|
Hi all! Thanks @thgoebel for updating the instructions! This looks good to me. My only suggestion would be to maybe add some context around the |
|
one additional comment, the launchpad instructions reference using |
|
I added references to wget and gpg and explained the commands a bit.
The short answer is: it's not that easy on Debian. The long answer is: PPAs are a Ubuntu thing and not really supported on Debian. Let's try it on Debian 12 (
So now we have:
That's a lot, considering we need really only need to download 1 file and add 1 line to another file. And it still doesn't work! Because So now we need to manually edit this file to change bookworm to jammy. ConclusionThat was a lot of words, but the conclusion is: PPAs are made for Debian not for Ubuntu. If you're lucky the PPA depends only on packages that Debian also ships (and in the right versions), and you just need to manually set the correct sources.list string. But the ecosystem (add-apt-repository) on Debian is not optimised for handling PPAs. Compared to that, wget and gpg are much smaller. And gpg you will need in any case (it comes as a dependency of software-properties-common). That's probably also why Signal has basically the same instructions and not add-apt-repository :) |
gotmax23
dismissed
their stale review
I'll take a look at the updated changes tomorrow
|
that makes sense to me @thgoebel. Thank you for the thorough followup! |
thgoebel
force-pushed
the
apt-key-deprecation
branch
from
02718a3 to
b26d4eb
Compare
thgoebel
force-pushed
the
apt-key-deprecation
branch
from
b26d4eb to
f91ca20
Compare
|
Done. Thank you for your suggestions! |
apt-key is deprecated for security reasons.
See https://stackoverflow.com/a/71384057/11076036
I tested the new instructions to work on both Debian 10 and 11.
I did not build the documentation to check whether it looks right (I'm too lazy to set up the environment). But Github renders it okay.