-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Enterprise via repo #345
Install Enterprise via repo #345
Conversation
lakrass
commented
Oct 28, 2024
•
edited
Loading
edited
- Add ability to install Vault Enterprise via HashiCorp repo
- Set the default value of the vault_version_repo_suffix variable according to the vault_enterprise variable
- Notify the service restart handler on installation via HashiCorp repo
- Removed check of non-existent variable "vault_install_remote_repo" in tasks/main.yml
- Preparations to release v2.5.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Thanks for your PR. I would like to split out the Nix parts to have a minimal PR.
Hey @sschmittsva, I included your latest changes from the master in this PR, responded to your comments and fixed a few things I agree with. We should discuss on releasing v2.5.9 with this PR. If we do a release by this PR, we should remove the "- WIP" from the changelog. If you plan other changes before releasing the next version, we could keep the "- WIP". Thank you for your help! :) |
I added two more small changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minor things before merging :)
Hello @FalcoSuessgott, thank you for your review. :) |
LGTM Atze :) |