Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Enterprise via repo #345

Merged

Conversation

lakrass
Copy link
Contributor

@lakrass lakrass commented Oct 28, 2024

  • Add ability to install Vault Enterprise via HashiCorp repo
  • Set the default value of the vault_version_repo_suffix variable according to the vault_enterprise variable
  • Notify the service restart handler on installation via HashiCorp repo
  • Removed check of non-existent variable "vault_install_remote_repo" in tasks/main.yml
  • Preparations to release v2.5.9

Copy link
Contributor

@sschmittsva sschmittsva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Thanks for your PR. I would like to split out the Nix parts to have a minimal PR.

.gitignore Outdated Show resolved Hide resolved
flake.lock Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
tasks/install_hashi_repo.yml Show resolved Hide resolved
tasks/main.yml Show resolved Hide resolved
tasks/main.yml Show resolved Hide resolved
@lakrass lakrass changed the title Install Enterprise via repo, updated Vault to v1.18.0 Install Enterprise via repo Dec 10, 2024
@lakrass
Copy link
Contributor Author

lakrass commented Dec 10, 2024

Hey @sschmittsva,

I included your latest changes from the master in this PR, responded to your comments and fixed a few things I agree with.
Feel free to check my PR again.

We should discuss on releasing v2.5.9 with this PR. If we do a release by this PR, we should remove the "- WIP" from the changelog. If you plan other changes before releasing the next version, we could keep the "- WIP".

Thank you for your help! :)

@lakrass
Copy link
Contributor Author

lakrass commented Dec 11, 2024

I added two more small changes:

  • set the default value of the vault_version_repo_suffix variable according to the vault_enterprise variable
  • notify the service restart handler on installation via HashiCorp repo

Copy link
Collaborator

@FalcoSuessgott FalcoSuessgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor things before merging :)

CHANGELOG.md Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@lakrass
Copy link
Contributor Author

lakrass commented Dec 11, 2024

Hello @FalcoSuessgott, thank you for your review. :)
I just fixed the remarks you issued.

@FalcoSuessgott
Copy link
Collaborator

LGTM Atze :)

@FalcoSuessgott FalcoSuessgott merged commit 8eeeeec into ansible-community:master Dec 11, 2024
11 checks passed
@lakrass lakrass deleted the enterprise-via-package branch December 11, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants