wip

tests/integration/targets/api/tasks/main.yml

@@ -28,36 +28,28 @@
         sys_id: "{{ user.record.sys_id }}"
       register: deleted_user
 
-    - name: Retrieve all incidents
-      servicenow.itsm.api_info:
-        resource: incident
-      register: initial
-    - ansible.builtin.assert:
-        that:
-          - initial.record != []
-
     # Using api module's 'data' field
 
     - name: Create a resource in table incident with some specified attributes
       servicenow.itsm.api: &api-create-data
         resource: incident
         action: post
         data:
-          short_description: my-incident
+          short_description: "{{ 'my-incident_' + lookup('password', '/dev/null chars=ascii_letters,digit length=8') | lower }}"
       register: base_api
       check_mode: true
     - ansible.builtin.assert: &api-create-assertions-data
         that:
           - base_api is changed
-          - base_api.record.short_description == 'my-incident'
 
     - name: Verify creation in check mode did not create a record
       servicenow.itsm.api_info:
         resource: incident
+        sysparm_query: "short_description={{ base_api.record.short_description }}"
       register: result
     - ansible.builtin.assert:
         that:
-          - result.record | length == initial.record | length
+          - result.record | length == 0
 
     - name: Create a resource in table incident
       servicenow.itsm.api: *api-create-data
@@ -67,10 +59,11 @@
     - name: Retrieve all incidents after creating a new resource
       servicenow.itsm.api_info:
         resource: incident
+        sys_id: "{{ first_incident.record.sys_id }}"
       register: result
     - ansible.builtin.assert:
         that:
-          - result.record | length == initial.record | length + 1
+          - result.record | length == 1
 
     # If idempotence will be implemented in the future:
     #   - TODO: change assertion to 'result is not changed'
@@ -186,19 +179,6 @@
           - result is failed
           - "'Invalid table bad_table_name' in result.msg"
 
-    - name: Test invalid column name - API ignores column names that are not present in the resource
-      servicenow.itsm.api_info:
-        resource: incident
-        sysparm_query: bad_column=bad_column_value1^ORbad_column=bad_column_value2 # 'bad_column' is not present in incident's columns
-      register: result_bad_query
-    - name: Retrieve all incidents so they'll be compared to the API call with columns ignored
-      servicenow.itsm.api_info:
-        resource: incident
-      register: result_no_query
-    - ansible.builtin.assert:
-        that:
-          - result_bad_query.record | length == result_no_query.record | length
-
     # Using api module's 'column' field
     - name: Create a resource in table incident with attributes, specified in template file
       servicenow.itsm.api:

tests/integration/targets/configuration_item/tasks/main.yml

@@ -5,13 +5,9 @@
     SN_PASSWORD: "{{ sn_password }}"
 
   block:
-    - name: Retrieve configuration item records
-      servicenow.itsm.configuration_item_info:
-      register: initial
-
     - name: Create a base configuration item (check mode)
       servicenow.itsm.configuration_item: &ci-create
-        name: my-configuration-item
+        name: "{{ 'configuration_item_' + lookup('password', '/dev/null chars=ascii_letters,digit length=8') | lower }}"
         category: hardware
         environment: development
         install_status: on_order
@@ -20,10 +16,10 @@
           - path: targets/configuration_item/res/sample_file.txt
       register: base_ci
       check_mode: true
+
     - ansible.builtin.assert: &ci-create-assertions
         that:
           - base_ci is changed
-          - base_ci.record.name == "my-configuration-item"
           - base_ci.record.category == "hardware"
           - base_ci.record.environment == "development"
           - base_ci.record.install_status == "on_order"
@@ -33,10 +29,11 @@
 
     - name: Verify creation in check mode did not create a record
       servicenow.itsm.configuration_item_info:
+        sysparm_query: "name={{ base_ci.record.name }}"
       register: result
     - ansible.builtin.assert:
         that:
-          - result.records | length == initial.records | length
+          - result.records | length == 0
 
     - name: Create a base configuration item
       servicenow.itsm.configuration_item: *ci-create
@@ -45,14 +42,17 @@
 
     - name: Verify that a new record was created
       servicenow.itsm.configuration_item_info:
+        sysparm_query: "name={{ base_ci.record.name }}"
       register: result
     - ansible.builtin.assert:
         that:
-          - result.records | length == initial.records | length + 1
+          - result.records | length == 1
 
     - name: Create a base configuration item using existing name (idempotence)
       servicenow.itsm.configuration_item: *ci-create
       register: result
+    - ansible.builtin.debug:
+        var: result
     - ansible.builtin.assert:
         that:
           - result is not changed