Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New modules: win_iis_mimetype, win_iis_mimetype_info #366

Closed
wants to merge 2 commits into from
Closed

New modules: win_iis_mimetype, win_iis_mimetype_info #366

wants to merge 2 commits into from

Conversation

git-cgallagher
Copy link

SUMMARY

New module win_iis_mimetype and win_iis_mimetype_info to solve for adding/removing mime types to IIS idempotently.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • win_iis_mimetype
  • win_iis_mimetype_info
ADDITIONAL INFORMATION
- Includes integration tests

@github-actions
Copy link

This pull request is stale because it has been open for 4 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.

@jborean93
Copy link
Collaborator

See #379 (comment). I'm reluctant to add even more modules to this collection. Especially so with the IIS modules which are already somewhat unmaintained and in a pretty rough shape. I'll be talking about this a bit more in the next Windows Working Group meeting ansible/community#644 to see what the general consensus is when it comes to accepting new modules in PRs for this collection going forward.

@github-actions github-actions bot removed the stale label Apr 20, 2022
@jborean93
Copy link
Collaborator

While there wasn't a concrete answer at the meeting in regards to new modules I'm sorry to say this isn't something that we are really interested in including at this particular point in time in this collection. The support and quality of the IIS modules already in this collection are rudimentary at best and we feel like trying to add more IIS features here isn't the best thing to do at this point in time.

I do apologise about the lateness of the review and thank you for contributing. The inclusion of tests is fantastic but for now I recommend you include this in your own collection if you wish for this to be distributed publicly.

@jborean93 jborean93 closed this Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants