Use JUnit5 on tests

[BrayanDSO]

Pull Request template

Purpose / Description

Describe the problem or feature and motivation

Fixes

Fixes #11201

Approach

1. Extract JUnit version to a constant, so all 3 testImplementations uses the same version
2. Add JUnitPlatform use to build.gradle
3. Fix imports to kotlin.test.junit5.JUnit5Asserter
4. Fix AbstractFlashcardViewerTest.getSignalFromUrlTest
   • It is currently the only parameterized test that uses jupiter-params. It wasn't being discovered before, so it haven't raised any exception.
   • Now that it's discovered, it needed to be fixed

How Has This Been Tested?

gradlew lint+ jacocoUnitTestReport

Learning (optional, can help others)

https://docs.gradle.org/current/userguide/java_testing.html#using_junit5
https://stackoverflow.com/a/68934967

Android JUnit isn't officially updated yet (links taken from a 3rd party Android JUnit5 repo)

InstantTaskExecutorRule uses @RestrictTo(RestrictTo.Scope.LIBRARY_GROUP) -- why? (issuetracker.google.com)
Add support for JUnit 5 (issuetracker.google.com)
android/android-test#224

Checklist

Please, go through these checks before submitting the PR.

• You have not changed whitespace unnecessarily (it makes diffs hard to read)
• You have a descriptive commit message with a short title (first line, max 50 chars).
• Your code follows the style of the project (e.g. never omit braces in if statements)
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner
  https://docs.gradle.org/current/userguide/java_testing.html#using_junit5 and https://stackoverflow.com/a/68934967

[BrayanDSO]

Now we can use junit parameterized tests, building some custom annotations later would be good IMO.

As an example here https://github.com/ankidroid/Anki-Android/pull/11202/files#diff-ec045306ef509765aeb114371f47e8e180c58c5ef7bfbe88f4bf51f7c0396378R255-R269 it could be passed the args directly to a annotation, so there is less boilerplate. Somewhat similar to python's pytest parameterized annotations

edit: https://www.baeldung.com/parameterized-tests-junit-5#8-custom-annotation can be an example

[mikehardy]

This looks great - my comments are both about maybe taking it farther, that is not just Anki-Android but also api and lint-rules module

[mikehardy]

did I just miss the junit in ext before? 😆 🤷
This looks great though, thanks for helping clean up the build files, been a while since I groomed them and entropy seemed to have taken over pretty quickly! Looking better now

[mikehardy]

@david-allison asking for high priority review since A) should be quick and B) blocks something else, I always try to clear blockers when possible. Thanks!

[david-allison]

LGTM. Thanks so much! Added one comment which has no action needed

@mikehardy - pinging in case you want to run this though your CI

[mikehardy]

Nope - this one can't really have cross-contamination. The ones we have been unlucky on are when Kotlin vs Java null/non-null typings have changed while there's 10 other PRs in the queue. For any of the normal stuff that can't cross-contaminate, I'm all for hitting the button personally