Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

Fixes issue #697. Text is now visible properly in Vocab Match Game. #1355

Closed
wants to merge 1 commit into from

Conversation

devanshi7799
Copy link

@devanshi7799 devanshi7799 commented Feb 22, 2020

Description

I have made changes in the activity_vocab_match_game.xml file. I have simply added padding value to keep the text at the centre of the image

Fixes #697

Type of Change:

Delete irrelevant options.

  • Code
  • Quality Assurance
  • User Interface
  • Outreach
  • Documentation

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

I have tested this on two android devices(vivo y51l and micromax HS2) and it works perfectly fine

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules
    WhatsApp Image 2020-02-22 at 11 59 28 PM
    WhatsApp Image 2020-02-22 at 11 59 29 PM

@mayburgos
Copy link

I have to close this PR since you were not assigned the issue. Please check our Contributing Guidelines and follow those steps.

@mayburgos mayburgos closed this Mar 4, 2020
@devanshi7799
Copy link
Author

@mayburgos sorry for doing this. I will take care about it in future

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Texts not visible properly in Vocab Match Game
2 participants