Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected the grammatical mistakes #58

Closed
wants to merge 6 commits into from

Conversation

unnati914
Copy link

@unnati914 unnati914 commented Jun 10, 2021

I have corrected the grammatical errors in different files, solves issue#49

Description

I have corrected the grammatical errors in different files. Eg some spelling mistakes

Fixes #49

Type of Change:

  • Documentation

Checklist:

  • My PR follows the style guidelines of this project
  • I have provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@devkapilbansal devkapilbansal linked an issue Jun 10, 2021 that may be closed by this pull request
@devkapilbansal
Copy link
Member

Hi @unnati914 please edit the description above and made necessary changes. Also, we do have a commit message guideline that should be followed.

P.S. :- I can't see any document file change. Only changes shown are in binary files. Can you please re check it?

@devkapilbansal devkapilbansal added Status: Needs Review PR needs an additional review or a maintainer's review. and removed Status: Changes Requested labels Jun 10, 2021
Copy link
Member

@devkapilbansal devkapilbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DESIGN_CONTRIBUTION_GUIDELINES.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
our-blog.md Outdated
@@ -43,7 +43,7 @@ Make sure to provide us with following details:
3. Select "Add to publication" option;
4. Select the AnitaB.org Open Source (you will see this in case you are a writer);
<img src="https://user-images.githubusercontent.com/11148726/87883600-78940a00-ca00-11ea-9534-49eabeff2f16.png" alt="AnitaB.org open source option in the dropdown" width="600"/>
5. Click submit!
5. Click submit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isabelcosta was the ! for dramatic effect :P ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loool @epicadk maybe maybe. Yes for encouragement. like a "hit publish and that's it! 🥳 "
it is a style choice :P

quality-assurance.md Outdated Show resolved Hide resolved
Copy link
Member

@devkapilbansal devkapilbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@unnati914 there are some more errors that can be fixed. I will suggest to use some grammar checker tool for that. 😃

ways-to-contribute.md Show resolved Hide resolved
ways-to-contribute.md Show resolved Hide resolved
@epicadk epicadk self-requested a review June 19, 2021 05:15
@@ -8,14 +8,14 @@ If you are here, it probably means you are either looking for a place to start c

## Contributing

We are glad to know that you would like to contribute to our open source projects. If you are new to our community, we strongly recommend getting through the following list.
We are glad to know that you would like to contribute to our open source projects. If you are new to our community, we strongly recommend getting through the following:-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We are glad to know that you would like to contribute to our open source projects. If you are new to our community, we strongly recommend getting through the following:-
We are glad to know that you would like to contribute to our open source projects. If you are new to our community, we strongly recommend getting through the following:

@unnati914 unnati914 closed this Aug 3, 2021
@isabelcosta
Copy link
Member

@unnati914 did you close because you don't want to continue working on this task?

@unnati914
Copy link
Author

I had open a new PR. Because I had some conflicts opening a new PR. I had worked on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review PR needs an additional review or a maintainer's review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix grammatical mistakes
5 participants