Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shared): LocalErrorBoundary에서 로그인 이동 'login'에서 'signin'으로 변경 #256

Merged
merged 2 commits into from
Dec 1, 2023
Merged

fix(shared): LocalErrorBoundary에서 로그인 이동 'login'에서 'signin'으로 변경 #256

merged 2 commits into from
Dec 1, 2023

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Nov 30, 2023

@sukvvon sukvvon added 🔥 Must have 우선순위 1순위 (프로젝트에 필수적인 기능) 🔨 Fix 버그 수정 또는 typo labels Nov 30, 2023
@sukvvon sukvvon added this to the Sprint_5 milestone Nov 30, 2023
@sukvvon sukvvon self-assigned this Nov 30, 2023
@sukvvon sukvvon linked an issue Nov 30, 2023 that may be closed by this pull request
bug: LocalErrorBoundary에 로그인 이동 로직 'login'에서 'signin'으로 교체 #255
Closed
@vercel Vercel
Copy link

vercel bot commented Nov 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
anifriends-frontend-shelter ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2023 5:52am
anifriends-frontend-volunteer ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2023 5:52am

kutta97
kutta97 reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@kutta97 kutta97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 로그인 대신 회원가입으로 이동해야할 이유가 있을까요?
  2. LocalErrorBoundary 컴포넌트를 파일의 가장 상단으로 이동한 이유가 있을까요?

@sukvvon sukvvon merged commit 7f763ed into develop Dec 1, 2023
2 checks passed
@sukvvon sukvvon deleted the fix/255 branch December 1, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kutta97 kutta97 kutta97 left review comments

@DongjaJ DongjaJ DongjaJ approved these changes

@Eosdia Eosdia Awaiting requested review from Eosdia

Assignees

@sukvvon sukvvon

Labels
🔨 Fix 버그 수정 또는 typo 🔥 Must have 우선순위 1순위 (프로젝트에 필수적인 기능)
Projects
None yet
Milestone
Sprint_5
Development

Successfully merging this pull request may close these issues.

bug: LocalErrorBoundary에 로그인 이동 로직 'login'에서 'signin'으로 교체
3 participants
@sukvvon @DongjaJ @kutta97