Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shared): Tabs 공통 컴포넌트 추가 #171

Merged
merged 2 commits into from
Nov 24, 2023
Merged

feat(shared): Tabs 공통 컴포넌트 추가 #171

merged 2 commits into from
Nov 24, 2023

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Nov 23, 2023

📌 이슈번호

📗 구현 내용

📖 구현 스크린샷

화면-기록-2023-11-24-오전-5 35 45

동영상 코드

import Tabs from 'shared/components/Tabs';

export default function VolunteersProfilePage() {
  return (
    <Tabs
      tabs={[
        ['봉사 후기', <p key={1}>봉사 후기</p>],
        ['봉사 이력', <p key={2}>봉사 이력</p>],
        ['봉사 소감', <p key={3}>봉사 소감</p>],
      ]}
    />
  );
}

📖 PR 포인트 & 궁금한 점

@sukvvon sukvvon added 🐣 Feat 새로운 기능 추가 💧 Should have 우선순위 2순위 (필수적인 업무는 아니지만 큰 개선효과를 일으킬 수 있는 업무) labels Nov 23, 2023
@sukvvon sukvvon added this to the Sprint_4 milestone Nov 23, 2023
@sukvvon sukvvon self-assigned this Nov 23, 2023
@sukvvon sukvvon linked an issue Nov 23, 2023 that may be closed by this pull request
feat: Tabs 공통 컴포넌트 추가 #170
Closed
1 task
@vercel Vercel
Copy link

vercel bot commented Nov 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
anifriends-frontend-shelter ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 6:50am
anifriends-frontend-volunteer ⬜️ Ignored (Inspect) Visit Preview Nov 24, 2023 6:50am

Eosdia
Eosdia requested changes Nov 24, 2023
View reviewed changes
packages/shared/components/Tabs.tsx
type TabNode = ReactNode;

type TabsProps = {
tabs: [TabName, TabNode][];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tab 을 클릭했을때 url 이동하는 함수를 실행하는 함수가 있었으면 좋겠습니다~!

@sukvvon sukvvon merged commit 88a920d into develop Nov 24, 2023
2 checks passed
@sukvvon sukvvon deleted the feat/170 branch November 24, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eosdia Eosdia Eosdia approved these changes

@DongjaJ DongjaJ Awaiting requested review from DongjaJ

@kutta97 kutta97 Awaiting requested review from kutta97

Assignees

@sukvvon sukvvon

Labels
🐣 Feat 새로운 기능 추가 💧 Should have 우선순위 2순위 (필수적인 업무는 아니지만 큰 개선효과를 일으킬 수 있는 업무)
Projects
None yet
Milestone
Sprint_4
Development

Successfully merging this pull request may close these issues.

feat: Tabs 공통 컴포넌트 추가
2 participants
@sukvvon @Eosdia