feat : withlogin, layout 수정 (#244)

* fix(volunteer): withlogin 컴포넌트 early return 추가 * feat(shared): 보호소 어플 회원가입 페이지에 접근가능하도록 허용, layout console 제거 * fix(shared): 봉사자 앱, 보호소 앱 react strict mode 제거
anifriends · Nov 30, 2023 · 816d9ec · 816d9ec
1 parent 9e6b867
commit 816d9ec
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 13 deletions.
diff --git a/apps/shelter/src/main.tsx b/apps/shelter/src/main.tsx
@@ -1,4 +1,3 @@
-import React from 'react';
 import ReactDOM from 'react-dom/client';
 
 import App from './App.tsx';
@@ -16,9 +15,5 @@ async function deferRender() {
 }
 
 deferRender().then(() => {
-  ReactDOM.createRoot(document.getElementById('root')!).render(
-    <React.StrictMode>
-      <App />
-    </React.StrictMode>,
-  );
+  ReactDOM.createRoot(document.getElementById('root')!).render(<App />);
 });
diff --git a/apps/volunteer/src/components/WithLogin.tsx b/apps/volunteer/src/components/WithLogin.tsx
@@ -6,7 +6,7 @@ export default function WithLogin({ children }: { children: ReactNode }) {
   const { user } = useAuthStore();
 
   if (user) {
-    children;
+    return children;
   }
 
   return <Navigate to="/signin" />;

diff --git a/apps/volunteer/src/main.tsx b/apps/volunteer/src/main.tsx
@@ -1,4 +1,3 @@
-import React from 'react';
 import ReactDOM from 'react-dom/client';
 
 import App from './App.tsx';
@@ -16,9 +15,5 @@ async function deferRender() {
 }
 
 deferRender().then(() => {
-  ReactDOM.createRoot(document.getElementById('root')!).render(
-    <React.StrictMode>
-      <App />
-    </React.StrictMode>,
-  );
+  ReactDOM.createRoot(document.getElementById('root')!).render(<App />);
 });
diff --git a/packages/shared/layout/index.tsx b/packages/shared/layout/index.tsx
@@ -21,6 +21,9 @@ export default function Layout({ appType }: LayoutProps) {
     if (appType === 'VOLUNTEER_APP' && pathname === '/') {
       navigate('/volunteers');
     } else if (appType === 'SHELTER_APP') {
+      if (pathname === '/signup' || pathname === '/signin') {
+        return;
+      }
       navigate('/signin');
     }