fix(material/toolbar): Update icon button color to match label text color token #30280
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amysorto
requested review from
crisbeto and
mmalerba
and removed request for
a team
crisbeto
reviewed
Jan 7, 2025
src/material/toolbar/toolbar.scss
Outdated
| @@ -56,6 +56,8 @@ $height-mobile-portrait: 56px !default; | |||
| @include token-utils.use-tokens( | |||
| tokens-mat-toolbar.$prefix, tokens-mat-toolbar.get-token-slots()) { | |||
| $color-token: token-utils.get-token-variable(container-text-color); | |||
| // Update icon button color to match label text color for consistency while overriding. | |||
| --mdc-icon-button-icon-color: $color-token; | |||
There was a problem hiding this comment.
We should do this through use-tokens, instead of hardcoding the name. See in the next few lines how it's done for the outlined and text buttons.
amysorto
force-pushed
the
toolbar-icon-color-overrides
branch
from
c0be42b to
1d35c12
Compare
crisbeto
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30279
Note: this only affects icon buttons that have the
mat-unthemedclass.