Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/datepicker): datepicker row count inaccurate for screen … #28760

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

essjay05
Copy link
Contributor

…reader

Fixes a bug in the Angular Material datepicker component where the divider row is being counted as a row. This is because the 'aria-hidden=true' was placed on its child th tag as opposed to the divider tr tag.

Fixes #28476

…reader

Fixes a bug in the Angular Material datepicker component where the divider
row is being counted as a row. This is because the 'aria-hidden=true' was
placed on its child th tag as opposed to the divider tr tag.

Fixes angular#28476
@zarend zarend added Accessibility This issue is related to accessibility (a11y) dev-app preview When applied, previews of the dev-app are deployed to Firebase labels Mar 21, 2024
@zarend
Copy link
Contributor

zarend commented Mar 21, 2024

Action Item: remember to smoke test on NVDA or JAWS with table navigation features

@zarend zarend added the target: patch This PR is targeted for the next patch release label Mar 21, 2024
Copy link
Contributor

@zarend zarend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Deployed dev-app for b7ef137 to: https://ng-dev-previews-comp--pr-angular-components-28760-dev-wgqn4uby.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@zarend zarend added the action: merge The PR is ready for merge by the caretaker label Mar 21, 2024
@zarend zarend removed the request for review from mmalerba March 26, 2024 18:08
@zarend zarend merged commit 457ce69 into angular:main Mar 26, 2024
31 checks passed
zarend pushed a commit that referenced this pull request Mar 26, 2024
…reader (#28760)

Fixes a bug in the Angular Material datepicker component where the divider
row is being counted as a row. This is because the 'aria-hidden=true' was
placed on its child th tag as opposed to the divider tr tag.

Fixes #28476

(cherry picked from commit 457ce69)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker dev-app preview When applied, previews of the dev-app are deployed to Firebase target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Datepicker): Accessibility screen reader identifies incorrect number of rows in calendar.
3 participants