fix specific code

angular-ui · Mar 1, 2019 · d267276 · d267276
1 parent c07ec13
commit d267276
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/dist/mention.js b/dist/mention.js
@@ -215,9 +215,9 @@ angular.module('ui.mention').controller('uiMention', ["$element", "$scope", "$at
       return false;
     }
 
-    var mentionExists = ~_this.mentions.map(function (mention) {
-      return mention.id;
-    }).indexOf(choice.id);
+    var mentionExists = _this.mentions.some(function (mention) {
+      return _this.encode(mention) === _this.encode(choice);
+    });
 
     // Add the mention, unless its already been mentioned
     if (!mentionExists) {

diff --git a/dist/mention.min.js b/dist/mention.min.js
diff --git a/example/example.js b/example/example.js
@@ -32,4 +32,4 @@ angular.module('example', ['ui.mention']).run(["$rootScope", function ($rootScop
   };
 });
 
-var choices = [{ first: 'bob', last: 'barker', id: 11123 }, { first: 'kenny', last: 'logins', id: '123ab-123' }, { first: 'kyle', last: 'corn', id: '123' }, { first: 'steve', last: 'rodriguez', id: 'hi' }, { first: 'steve', last: 'holt', id: '0-9' }, { first: 'megan', last: 'burgerpants', id: 'ab-' }];
+var choices = [{ first: 'bob', last: 'barker', id: 11123 }, { first: 'kenny', last: 'logins', id: '123ab-123' }, { first: 'kyle', last: 'corn', id: '123' }, { first: 'steve', last: 'rodriguez', id: 'hi' }, { first: 'steve', last: 'holt', id: '0-9' }, { first: 'megan', last: 'burgerpants', id: 'ab-' }];
diff --git a/src/mentionController.es6.js b/src/mentionController.es6.js
@@ -187,7 +187,8 @@ $element, $scope, $attrs, $q, $timeout, $document
       return false;
     }
 
-    const mentionExists = ~this.mentions.map(mention => mention.id).indexOf(choice.id);
+    const mentionExists = this.mentions
+      .some(mention => this.encode(mention) === this.encode(choice));
 
     // Add the mention, unless its already been mentioned
     if (!mentionExists) {
-Original file line number
+Diff line change
@@ Expand Up @@
       };
     });
-    var choices = [{ first: 'bob', last: 'barker', id: 11123 }, { first: 'kenny', last: 'logins', id: '123ab-123' }, { first: 'kyle', last: 'corn', id: '123' }, { first: 'steve', last: 'rodriguez', id: 'hi' }, { first: 'steve', last: 'holt', id: '0-9' }, { first: 'megan', last: 'burgerpants', id: 'ab-' }];
+    var choices = [{ first: 'bob', last: 'barker', id: 11123 }, { first: 'kenny', last: 'logins', id: '123ab-123' }, { first: 'kyle', last: 'corn', id: '123' }, { first: 'steve', last: 'rodriguez', id: 'hi' }, { first: 'steve', last: 'holt', id: '0-9' }, { first: 'megan', last: 'burgerpants', id: 'ab-' }];