Create a new pull request by comparing changes across two branches #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf measurments have revealed that `data-*` attributes are slower to set than classes. PR Close #59273
PR Close #59277
Fix visibility issue with text inside polygon nodes in mermaid diagrams when using dark mode theme to ensure proper contrast and readability PR Close #59285
This PR adds error NG0750 to Error Encyclopedia. Update adev/src/content/reference/errors/NG0750.md Co-authored-by: Andrew Kushnir <[email protected]> Update adev/src/content/reference/errors/NG0750.md Co-authored-by: Andrew Kushnir <[email protected]> PR Close #59265
See associated pull request for more information. PR Close #59361
See associated pull request for more information. PR Close #59298
See associated pull request for more information. PR Close #59299
…perly (#58040) In this commit, we're replacing the `async-await` style in the playground component with the `from()` observable, which allows us to invert a dependency and avoid memory leaks. Because an `async` function has a closure, just like any other function in JavaScript, using `await` captures `this` until the promise is resolved. PR Close #58040
This commit updates the timeout used in the incremental hydration tests from `101` -> `10` ms, which allows to speed up tests by ~20% (12.5 -> 10 seconds locally). PR Close #59275
Exports the error codes so that they can be reused. PR Close #59353
In v19 we added a warning about unused standalone imports, however we didn't do anything about existing code which means that users have to clean it up manually. These changes add the `ng g @angular/core:cleanup-unused-imports` schematic which will remove the unused dependencies automatically. There isn't any new detection code since all the manipulations are based on the produced diagnostics, but there's a bit of code to remove the import declarations from the file as well. Fixes #58849. PR Close #59353
added split area component to demo component so that we can resize the devtools and demo app. PR Close #58818
Some time ago we narrowed down the expressions we support in two-way bindings, because in most cases any apart from property reads doesn't make sense. This ended up preventing users from using `$any` in the binding since it's considered a function call. These changes update the validation logic to allow `$any`. Fixes #51165. PR Close #59362
… HMR dependencies (#59323) During the HMR dependency analysis we need to check if an identifier is top-level or not. We do this by looking at each identifier and its parent, however we didn't account for some cases. These changes expand our logic to cover more of the common node types. Related to #59310 (comment). PR Close #59323
…class metadata is disabled (#59313) Fixes that the compiler wasn't capturing defer block dependencies correctly when `supportTestBed` is disabled. We had tests for this, but we didn't notice the issue because the dependencies ended up being captured because of the `setClassMetadata` calls. Once they're disabled, the dependencies stopped being recorded. Fixes #59310. PR Close #59313
In this commit, we replace `private warnIfDestroyed` with a `warnIfDestroyed` function that can be completely removed in production. This change is necessary because, with `private warnIfDestroyed`, the empty method is still retained in production, even though it has no body. PR Close #59269
Those were also properties that were kept to also support of old compiled targets. PR Close #59209
…mode (#59325) `ts_project` interop does not emit `.mjs` files. We could achieve this in the interop rule, but it's better to just fallback look for `.js`. In addition, `ng_package` currently fails because there is no `module_name` retrievable from the interop rule; hence causing in incorrect packaging and safety errors being thrown. PR Close #59325
Replaces `mapTo` with `map` because, in RxJS, `mapTo` is deprecated and internally uses `map`. PR Close #59333
Currently the `ɵEmptyOutletComponent` is very prone to generating ID collision warnings with user code, because it only has one child and no other metadata. This shows up some of our tests as well. While users can resolve it on their end, it can be confusing since they won't have any references to `ɵEmptyOutletComponent` in their own code. These changes add an `exportAs` to it to make its component ID unique. This doesn't affect the public API of the component since users can't use it directly anyways. PR Close #59300
See associated pull request for more information. PR Close #59291
GulajavaMinistudio
merged commit 6b2cbd9
into
angular-indonesia:main
4 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information