Create a new pull request by comparing changes across two branches #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See associated pull request for more information. PR Close #57631
See associated pull request for more information. PR Close #57633
See associated pull request for more information. PR Close #57636
See associated pull request for more information. PR Close #57634
Adds an explicit test to state the situation about non-null assertions and that we don't remove the exclamation marks here for now. PR Close #57629
…gnal input migration (#57629) Sometimes `--strictPropertyInitialization` is not enabled, while strict null checks is enabled. In those cases, `undefined` cannot be used as initial value with `input()`, nor can we expand the type of the input. We can migrate those instances to `undefined!` to preserve the original semantics and behavior. In addition, in the future we may leave a TODO or we may consider skipping migration of such inputs. PR Close #57629
…e integration (#57606) Instead of some special hook that relies on mutation to filter inputs in the signal input migration, we are now introducing a new configuration interface where the language-service can pass a filter method. This makes the code more readable. We also need the filter method to support filtering based on directories. E.g. when the migration runs against sub-folders, all inputs outside of the folder should be considered incompatible; to not migrate incorrectly. PR Close #57606
Initial version of the migration that changes decorator-based outputs to the equivalent form using new authoring functions. PR Close #57604
We don't need to ship the migrations for v18 once we're in v19. PR Close #57603
…ndling (#57602) Replaces esbuild with Rollup for bundling schematics to support code splitting, as esbuild does not handle code splitting when targeting CommonJS modules. **Before:** ``` du -sh dist/bin/packages/core/npm_package/schematics 7.7M dist/bin/packages/core/npm_package/schematics ``` **After:** ``` du -sh dist/bin/packages/core/npm_package/schematics 3.1M dist/bin/packages/core/npm_package/schematics ``` PR Close #57602
Previously Elements was assuming that every output was an RxJS `Subject` and supports `.pipe()`. This is not true for `output()`-based outputs which have `.subscribe()` but not `.pipe()`. This commit fixes such outputs by using a `new Observable` instead of `map` to forward outputs. PR Close #57535
Implement the `afterRenderEffect` primitive, which creates effect(s) that run as part of Angular's `afterRender` sequence. `afterRenderEffect` is a useful primitive for expressing DOM operations in a declarative, reactive way. The API itself mirrors `afterRender` and `afterNextRender` with one big difference: values are propagated from phase to phase as signals instead of as plain values. As a result, later phases may not need to execute if the values returned by earlier phases do not change. PR Close #57549
) Instead of creating instances of refactoring whenever the language service loads, we should lazily create these upon first "application". This will speed up loading of the language service, while it also gives us the ability to implement caching in code refactorings to speed up subsequent applications; leveraging e.g. the `script versions` from the TS server project. PR Close #57645
) This commit shares the logic for looking up a property access, using `ts.Type` information. This is helpful in case where no linked TS symbols are available; e.g. templates in test files without TCB. This helper will be useful for handling object expansion in the signal input migration; resolving references like `const {x} = this`. PR Close #57645
…ration (#57645) Currently we detect element bindings as normal references and inside usages we simply unwrap its usages. This works, but breaks in situations like the following: - When the expressions are narrowed. Narrowing analysis does not support aliased inputs. E.g. `const {myInput: alias} = this`. We could add this, but it would complexify the logic. - When binding patterns deeply access value properties directly. E.g. `const {myInput: {value}} = this;` In addition, the current approach requires us to understand that aliases may point to inputs. This means we need to check all identifiers if they point to Angular inputs. We could optimize this, but it's much easier if we can simply assume that we only need to "verify" identifiers that have names of "known inputs". This would significantly speed up turnaround in the language service integration. In addition, it would be more _correct_, semantically to directly access the value of the input at object expansion, versus later. PR Close #57645
Adds a new diagnostic that will report cases where a declaration is in the `imports` array, but isn't being used anywhere. The diagnostic is reported as a warning by default and can be controlled using the following option in the tsconfig:
```
{
"angularCompilerOptions": {
"extendedDiagnostics": {
"checks": {
"unusedStandaloneImports": "suppress"
}
}
}
}
```
**Note:** I'll look into a codefix for the language service in a follow-up.
Fixes #46766.
PR Close #57605
See associated pull request for more information. PR Close #57649
A set of fixes to the import paths - the goal is to make the output migration compatible with the G3 infrastructure. PR Close #57654
This commits extends the decorator-based output migration to replace .next usage (not supported with the output function) with .emit (supported in both decorator-based and function based outputs). PR Close #57654
…ow function (#57659) Whenever the signal migration discovers multiple references in the same control flow container, it assumes narrowing and wants to preserve this functionality. It does this by introducing temporary variables. This works fine, but currently there is an edge case with arrow functions, as those can also turn into blocks, but aren't considered as such in the current code. This commit fixes this, so that arrow functions will be converted to be block-based if necessary. PR Close #57659
…refactoring (#57659) Instead of printing the enum name as the reason why migration did not complete, we should print some human-readable descriptions. This commit implements this. This logic may also be useful for the devkit comment generation, or CLI usage. In addition, we expose another VSCode refactoring to try via best effort mode. There is no way for prompting, or adding multiple actions for the same refactoring, so we expose a new refactoring. PR Close #57659
…57659) With the preparation work from previous commits, we are able to reduce analysis time of the migration from e.g. whole Material repo 7seconds to 0.1seconds when the migration is invoked via the VSCode extension. This is possible because we can avoid many expensive type checking lookups if we know what inputs are actually migrated. We do this by adding some naive pre-check to see if identifiers are possibly pointing to a migrated input. This is possible now because we no longer migrate aliased identifiers for object expansion, but instead migrate directly at object expansion declaration. This allows us to assume that all possible references to inputs must go through identifiers that are named like the original input class field name. PR Close #57659
…riables (#57659) Whenever we migrate object expansion patterns, we may need a temporary variable to generate a construct like: ```ts const {bla: blaValue} = this; const bla = blaValue(); ``` We should instead use `blaInput` as the name for the temporary variable. For narrowing constants, `blaValue` is correct, but here it's an actual reference to the input / signal. PR Close #57659
Instead of encouraging deep imports, we should expose commonly accessed exports in a `index.ts` barrel file. PR Close #57659
Refactor the directive-forest components to use signal apis, in future we can make the components onPush and zoneless PR Close #56998
GulajavaMinistudio
merged commit 447f42f
into
angular-indonesia:main
4 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information