Create a new pull request by comparing changes across two branches #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iif needed `tslib` code is included directly in the bundled FESM2015 hence making the dependency redundant. PR Close #55827
) The Angular CLI documentation topic for migrating to the new build system now has a navigation label of "Migrating to new build system" instead of "esbuild". This new label better reflects the action a user may want to take rather than one of the tools used by the new build system. PR Close #55782
… input with restricted access (#55774) Currently when attempting to retrieve a TCB symbol for an input binding that refers to a signal input with e.g. `protected`, while the `honorAccessModifiersForInputBindings` flag is `false`, Angular will throw a runtime exception because the symbol retrieval code always expects a proper field access in the TCB. This is not the case with `honorAccessModifiersForInputBindings = false`, as TCB will allocate a temporary variable when ignoring the field access. This will then trigger the runtime exception (which we added to flag such "unexpected" cases). This commit handles it gracefully, as it's valid TCB, but we simply cannot generate a proper TCB symbol (yet). This is similar to `@Input` decorator inputs. In the future we may implement logic to build up TCB symbols for non-property access bindings, for both signal inputs or `@Input` inputs. This commit just avoids a build exception. Related to: #54324. PR Close #55774
GulajavaMinistudio
merged commit 082dfdf
into
angular-indonesia:main
7 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information