forked from angular/angular
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a new pull request by comparing changes across two branches #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first test asserts that bubbling does not work right now. The second asserts that stopPropagation works, which should pass when test #1 passes too. The third test asserts properties about the events passed to the event handler. THe fourth test asserts that mouse events do not translate to jsaction nor help emit the jsaction binary. This required a change in code to make this pass. PR Close #55747
This reuses information already recorded during hydration to remove jsaction attributes to also stash event handlers. This avoids a tree walk and looku. PR Close #55747
See associated pull request for more information. PR Close #55781
Release angular.dev on each commit to the appropriate version of the documentation site based on the current state of the repository. PR Close #55792
See associated pull request for more information. PR Close #55785
Angular has long had the ability to use different interpolation delimiters (by default `{{` and `}}`). This concept was copied over from AngularJS, where AngularJS syntax is included in HTML sent over the network to the browser. Occasionally developers would use SSR frameworks which _also_ have interpolation syntaxes of their own, so there was a need to change the delimiters used by AngularJS to avoid conflicts. Since Angular templates are always processed by our compiler and the interpolation characters are never processed by other systems first, this option is vestigial in Angular and only increases the complexity of our parser. DEPRECATED: `@Component.interpolation` is deprecated. Use Angular's delimiters instead. PR Close #55778
Properly rely on the adev job so that the job actually triggers PR Close #55797
This is a simple move. PR Close #55756
This will enable internal usages to migrate from ActionResolver in EventContrat to ActionResolver in Dispatcher. PR Close #55757
GulajavaMinistudio
merged commit May 15, 2024
f55b23f
into
angular-indonesia:main
7 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information