Create a new pull request by comparing changes across two branches #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `cleanUp` is called `containerManager` is set to null. Currently the `EventContract` API assumes that users know not to call further methods on `EventContract`, but this lead to a bug in a downstream app, b/333750059. So instead, this makes a defensive check to make sure it's not null. PR Close #55353
Flip `stopPropagation` constructor parameter default to `false` for `EventContract` and `EventContractMultiContainer`. Change type for `EventContract` to `false` to indicate that no values besides `false` should be passed. This enables removing all usages of `stopPropagation` in `EventContract` and leaving only usages of `stopPropagation = true` for `EventContractMultiContainer`. PR Close #55351
See associated pull request for more information. PR Close #55358
For ideal DOM usage, you would not unwrap an ElementRef outside of the browser. However, it's reasonable to want to find the tag name of the host node on the server, and so this introduces a HOST_TAG_NAME token that can be injected to read this value. PR Close #54751
…scing and zoneless (#55352) This commit ensures we correctly handle the exit from the zone.run in the zoneless scheduler. Run coalescing would delay the `onMicrotaskEmpty` event until after we have exited the change detection triggered by the zoneless scheduler and mean that the subscription cannot determine if `ApplicationRef.tick` should be skipped. PR Close #55352
…rects (#55370) This commit adds the ability to return `RedirectCommand` from the error handler provided by `withNavigationErrorHandler`. This will prevent the error from being surfaced in the `events` observable of the Router and instead convert the error to a redirect. This allows developers to have more control over how the Router handles navigation errors. There are some cases when the application _does not_ want the URL to be reset when an error occurs. resolves #42915 PR Close #55370
Migrate formatting to prettier for core/primitives from clang-format PR Close #55387
Migrate formatting to prettier for compiler from clang-format PR Close #55398
Migrate formatting to prettier for language-service from clang-format PR Close #55405
This update modifies the transfer cache logic to prevent caching of HTTP requests that require authorization. To opt-out from this behaviour use the `includeRequestsWithAuthHeaders` option in `withHttpTransferCache`
BREAKING CHANGE: By default we now prevent caching of HTTP requests that require authorization . To opt-out from this behaviour use the `includeRequestsWithAuthHeaders` option in `withHttpTransferCache`.
Example:
```ts
withHttpTransferCache({
includeRequestsWithAuthHeaders: true,
})
```
Closes: #54745
PR Close #55034
…ttern in zoneless (#55231) There is an existing pattern that zone-based applications use to avoid `ExpressionChangedAfterItHasBeenCheckedError` which is also used in `NgModel`: update the state in a microtask instead of doing it synchronously. This defers the state update to another round of change detection, and with ZoneJS, also still executes in the same event loop. These types of changes across multiple rounds of change detection were still executed before the browser paint. This update allows the `NgModel` workaround to continue working in Zoneless. This may not be permanent and is certainly still not advisable. Render hooks (`afterNextRender`/`afterRender`) will execute between these rounds of change detection when they are intended to be run after all DOM updates completed. PR Close #55231
This commit adds helpful stack information for the case when change detection continues to be triggered in the event loop and would cause the browser to freeze. PR Close #55231
…in basic mode (#55360) Angular only checks the contents of template nodes in full type checking mode. After v17, the new control flow always had its body checked, even in basic mode, which started revealing compilation errors for apps that were using the schematic to automatically switch to the new syntax. These changes mimic the old behavior by not checking the bodies of `if`, `switch` and `for` blocks in basic mode. Note that the expressions of the blocks are still going to be checked. Fixes #52969. PR Close #55360
Path should have a leading slash. PR Close #55388
This commit removes of migrations introduced in version 17, along with the relocation of a migration from 17.3 to version 18. This ensures that this is ran for users who may have updated from one minor to another without executing `ng update` PR Close #55391
See associated pull request for more information. PR Close #54891
See associated pull request for more information. PR Close #55419
Migrate formatting to prettier for forms from clang-format PR Close #55423
Migrate formatting to prettier for localize from clang-format PR Close #55423
Migrate formatting to prettier for platform-* from clang-format PR Close #55423
GulajavaMinistudio
merged commit 4751f60
into
angular-indonesia:main
7 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information