Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a new pull request by comparing changes across two branches #159

Merged
merged 6 commits into from
Dec 6, 2023
Merged

Create a new pull request by comparing changes across two branches #159

merged 6 commits into from
Dec 6, 2023

Conversation

GulajavaMinistudio
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

JeanMeche and others added 6 commits December 5, 2023 12:42
@JeanMeche @dylhunn
refactor(devtools): enables typescript strict option (#53340)
6cd91c6 
Enabling `strict` is part of an effort to improve the quality of the devtools code base.
One of the direct side effect is to enable `noImplicitAny`, `strictPropertyInitialization` and `strictBindCallApply`.

This commit also replaces `fullTemplateTypeCheck` with `stringTemplates`.

PR Close #53340
@dylhunn
refactor(compiler): Initial support for i18n attributes (#53341)
05f9c7b 
Add support for i18n attributes:
- Generate i18n contexts from i18n attributes, and extract the eventual messages into the constant pool.
- Emit I18nAttributes config instructions when needed.
- Use the generated i18n variable in the appropriate places, including extracted attribute instructions, as well as I18nAttributes config arrays.

PR Close #53341
@thePunderWoman @dylhunn
fix(migrations): handle nested ng-template replacement safely in CF m…
5a0ed28 
…igration (#53368)

When there are ng-templates nested inside other ng-templates, the replacement and removal of the templates gets disrupted. Re-processing the templates in the file along the way resolves this issue.

fixes: #53362

PR Close #53368
@thePunderWoman @dylhunn
fix(migrations): handle templates outside of component in cf migration (
01b18a4 
#53368)

If a template is passed in as an input, the ng-template will not exist in the same component template. This will leave a template placeholder behind. This fix ensures that template placeholder gets turned into a template outlet.

fixes: #53361

PR Close #53368
@JeanMeche @dylhunn
refactor(devtools): run control flow migration. (#53353)
8195be1 
Let's update the devtools with the latest improvements !

PR Close #53353
@crisbeto @dylhunn
fix(compiler-cli): add compiler option to disable control flow conten…
e620b3a 
…t projection diagnostic (#53311)

These changes add an option to the `extendedDiagnostics` field that allows the check from #53190 to be disabled. This is a follow-up based on a recent discussion.

PR Close #53311
@GulajavaMinistudio GulajavaMinistudio merged commit 779fba9 into angular-indonesia:main Dec 6, 2023
7 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GulajavaMinistudio @JeanMeche @dylhunn @thePunderWoman @crisbeto