Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a new pull request by comparing changes across two branches #157

Merged
merged 17 commits into from
Dec 4, 2023
Merged

Create a new pull request by comparing changes across two branches #157

merged 17 commits into from
Dec 4, 2023

Conversation

GulajavaMinistudio
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

AndrewKushnir and others added 17 commits December 1, 2023 09:12
@AndrewKushnir @dylhunn
fix(compiler): generate proper code for nullish coalescing in styling…
77ac4cd 
… host bindings (#53305)

This commit fixes an issue where having an expression with nullish coalescing in styling host bindings leads to JS errors due to the fact that a declaration for a temporary variable was not included into the generated code.

Resolves #53295.

PR Close #53305
@AndrewKushnir @dylhunn
fix(core): support hydration for cases when content is re-projected u…
4b23221 
…sing ng-template (#53304)

This commit fixes an issue with hydration, which happens when a content is projected in a certain way, leaving host elements non-projected, but the child content projected.

The fix is to detect such situations and add extra annotations to help runtime logic locate those elements at the right locations.

Resolves #53276.

PR Close #53304
@thePunderWoman @dylhunn
fix(migrations): CF Migration - Fix case of aliases on i18n ng-templa…
2998d48 
…tes preventing removal (#53299)

i18n template removal expected no other attributes to be present, but if a bound ngIf is present with aliases and i18n, that is more than what was expected. Now it should safely remove them appropriately.

fixes: #53289

PR Close #53299
@thePunderWoman @dylhunn
fix(migrations): CF migration - ensure NgIfElse attributes are proper…
1c1e8c4 
…ly removed (#53298)

the attribute in question was assumed to be at the start of the replaced content, but it could be later, too.

fixes: #53288

PR Close #53298
@thePunderWoman @dylhunn
fix(migrations): CF Migration add support for ngIf with just a then (#…
aad5e5b 
…53297)

Prior to this fix, the expectation that anytime then was used, else would always be present. That is not a valid assumption.

fixes: #53287

PR Close #53297
@clydin @dylhunn
fix(compiler): allow TS jsDocParsingMode host option to be programmat…
5613051 
…ically set again (#53292)

When the AOT compiler creates a delegated host for a provided TypeScript CompilerHost,
it delegates functionality back to the original via a series of internal method delegations.
However, unlike other members of the CompilerHost, `jsDocParsingMode` is not a method
and cannot be delegated in this way. Attempting to call bind on the property will result
in a runtime error. Instead, `jsDocParsingMode` is now delegated via get/set accessors.
Additionally, the override of `getSourceFile` now has an updated type signature to reflect
the additional of the `jsDocParsingMode` option for the method.

This is a followup to #53126 which updates the other DelegatingCompilerHost.

PR Close #53292
@AndrewKushnir @dylhunn
fix(core): support swapping hydrated views in @for loops (#53274)
82609d4 
This commit fixes an issue where swapping hydrated views was not possible in the new control flow repeater. The problem was caused by the fact that an internal representation of a view had no indication that hydration is completed and further detaching/attaching should work in a regular (non-hydration) mode. This commit adds a logic that resets a pointer to a dehydrated content and we use this as an indication that the view is swtiched to a regular mode.

Resolves #53163.

PR Close #53274
@JeanMeche @dylhunn
docs: Error codes should start with a 0. (#53271)
9f3e64a 
Also adding NG0602 to adev.

PR Close #53271
@pBouillon @dylhunn
docs: fix the colspan and colSpan link in the property binding page (#…
9423c19 
…53180)

PR Close #53180
@mmalerba @dylhunn
refactor(compiler): Put i18n expression ops in the correct order (#53300
a9fb5fa 
)

When we re-assign the slot dependencies for the i18nExprs, we should
move them down below the other ops that target their same slot. This
keeps the behavior consistent with TDB

PR Close #53300
@mmalerba @dylhunn
refactor(compiler): Handle i18n placeholders with spaces (#53300)
4afa5ac 
I18n placeholders may contain spaces, this change updates the formatting
logic to replace them with underscores in the output.

PR Close #53300
@mmalerba @dylhunn
refactor(compiler): Add support for ICUs that share a placeholder (#5…
e23752c 
…3300)

ICUs may share a placeholder, and in that case they need special
post-processing. This change adds logic to cover this possibility. In
particular, we set the param to a special placeholder value and then
pass an array containing the sub-message variables as a post-processing
param.

PR Close #53300
@mmalerba @dylhunn
refactor(compiler): Remove invalid assertion about i18n params (#53300)
2b3f06a 
We previously had an assertion that every placeholder in the i18n AST
had a corresponding param in the output. However, there are some cases
such as interpolations nested inside ICUs where this assertion is not
true. This change simply removes the asserion.

PR Close #53300
@mmalerba @dylhunn
refactor(compiler): Fix ingestion of nested ICUs (#53300)
8c34ad5 
It is possible for ICUs to be nested inside other ICUs. This change
adjusts our ingestion logic to create extra interpolation ops for the
nested ICUs during ingestion.

PR Close #53300
@mmalerba @dylhunn
test(compiler): Enable newly passing tests (#53300)
9bd9065 
Enables additional tests that pass after implementing the ICU logic.

PR Close #53300
@mmalerba @dylhunn
docs(compiler): Improve code comments (#53300)
acd6100 
Adds better comments describing the case where we have multiple ICU
sub-messages that share the same plaeholder.

PR Close #53300
@dylhunn
Revert "fix(router): Ensure canMatch guards run on wildcard routes (#…
d4b4236 
…53239)" (#53339)

This reverts commit 1940280.

PR Close #53339
@GulajavaMinistudio GulajavaMinistudio merged commit daf7b1b into angular-indonesia:main Dec 4, 2023
7 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@GulajavaMinistudio @AndrewKushnir @thePunderWoman @clydin @JeanMeche @pBouillon @mmalerba @dylhunn