Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a new pull request by comparing changes across two branches #153

Merged
merged 19 commits into from
Nov 21, 2023
Merged

Create a new pull request by comparing changes across two branches #153

merged 19 commits into from
Nov 21, 2023

Conversation

GulajavaMinistudio
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

timdeschryver and others added 19 commits November 20, 2023 08:54
@timdeschryver @AndrewKushnir
docs: update defer test snippet (#53056)
130c84e 
PR Close #53056
@timdeschryver @AndrewKushnir
docs: update defer testing snippet (#53056)
5482389 
PR Close #53056
@arturovt @AndrewKushnir
fix(core): cleanup loading promise when no dependencies are defined (#…
ed0fbd4 
…53031)

This commit cleans up the `loadingPromise` when no `dependenciesFn` is defined,
as it's already cleaned up after the resolution of `Promise.allSettled`. This
occurs with `prefetch on` triggers, such as when `triggerResourceLoading` is called
from `ɵɵdeferPrefetchOnImmediate`, where there are no dependencies to load. The
`loadingPromise` should still be cleaned up because it typically involves the
`ZoneAwarePromise`, which isn't properly garbage collected when referenced elsewhere
(in this case, it would be referenced from the `tView` data).

PR Close #53031
@Nicoss54 @AndrewKushnir
docs: example code afterNextRender phase (#53025)
f84057d 
Currently in the angular.dev documentation, afterNextRender function
take directly the phase as a second parameter which is not correct.
According to the api of this hook, the second parameter is an object
which contains the phase. This PR update the part of the documentation

PR Close #53025
@thePunderWoman @AndrewKushnir
fix(migrations): Fixes control flow migration if then else case (#53006)
5564d02 
With if then else use cases, we now properly account for the length
of the original element's contents when tracking new offsets.

fixes: #52927

PR Close #53006
@thePunderWoman @AndrewKushnir
fix(migrations): fixes migrations of nested switches in control flow (#…
28f6cbf 
…53010)

This separates out the NgSwitch migration pass from the NgSwitchCase / Default pass, which makes nested switch migrations work.

fixes: #53009

PR Close #53010
@arturovt @AndrewKushnir
fix(common): scan images once page is loaded (#52991)
7affa57 
This commit updates the implementation of the `ImagePerformanceWarning` and
runs the image scan even if the page has already been loaded. The `window.load`
event would never fire if the page has already been loaded; that's why we're
checking for the document's ready state.

PR Close #52991
@arturovt @AndrewKushnir
fix(common): remove load on image once it fails to load (#52990)
29c5416 
This commit adds an `error` listener to image elements and removes both
`load` and `error` listeners once the image loads or fails to load. The `load`
listener would never have been removed if the image failed to load.

PR Close #52990
@AnthonyFr75 @AndrewKushnir
fix(migrations): control flow migration fails for async pipe with unb…
e33f6e0 
…oxing of observable (#52756) (#52972)

Update control flow syntax to use 'as' for proper async pipe handling, accounting for variable whitespace before 'let'.

Fixes #52756

PR Close #52972
@crisbeto @AndrewKushnir
fix(compiler): produce placeholder for blocks in i18n bundles (#52958)
5fb707f 
When blocks were initially implemented, they were represented as containers in the i18n AST. This is problematic, because block affect the structure of the message.

These changes introduce a new `BlockPlaceholder` AST node and integrate it into the i18n pipeline. With the new node blocks are represented with the `START_BLOCK_<name>` and `CLOSE_BLOCK_<name>` placeholders.

PR Close #52958
@crisbeto @AndrewKushnir
fix(compiler): generate i18n instructions for blocks (#52958)
406049b 
Adds support for generating i18n instructions inside of blocks.

Fixes #52540.
Fixes #52767.

PR Close #52958
@thePunderWoman @AndrewKushnir
fix(migrations): tweaks to formatting in control flow migration (#53058)
e090b48 
This addresses a few minor formatting issues with the control flow migration.

fixes: #53017

PR Close #53058
@AndrewKushnir
docs: release notes for the v17.0.4 release
2ecda9f
@AndrewKushnir
release: cut the v17.1.0-next.1 release
33959f4
@zhysky @AndrewKushnir
docs: fix packages\core\src\application_init.ts (#53040)
d9a1528 
PR Close #53040
@JeanMeche @AndrewKushnir
refactor(core): replace runInContext by runInInjectionContext (#5…
e00ae2d 
…3035)

Saves a few bytes since function names can be mangled.

PR Close #53035
@atscott @AndrewKushnir
fix(core): Reattached views that are dirty from a signal update shoul…
b35c673 
…d refresh (#53001)

Related to #52928 but `updateAncestorTraversalFlagsOnAttach` is called
on view insertion and _should_ have made that work for views dirty from
signals but it wasn't updated to read the `dirty` flag when we changed
it from sharing the `RefreshView` flag.

For #52928, we've traditionally worked under the assumption that this is working
as expected.  The created view is `CheckAlways`. There is a question of whether we
should automatically mark things for check when the attached view has
the `Dirty` flag and/or has the `FirstLViewPass` flag set (or other
flags that indicate it definitely needs to be prefreshed).

PR Close #53001
@leonelvsc @AndrewKushnir
fix(router): Resolvers in different parts of the route tree should be…
29e0834 
… able to execute together (#52934)

The following commit accidentally broken execution of resolvers when
two resolvers appear in different parts of the tree and do not share a
3278966

This happens when there are secondary routes. This test ensures that all
routes with resolves are run.

fixes #52892

PR Close #52934
@crisbeto @AndrewKushnir
fix(core): inherit host directives (#52992)
c7c7ea9 
Adds support for inheriting host directives from the parent class. This is consistent with how we inherit other features like host bindings.

Fixes #51203.

PR Close #52992
@GulajavaMinistudio GulajavaMinistudio merged commit abdf438 into angular-indonesia:main Nov 21, 2023
7 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.