feat(ng-add): integrate with ng-add #14
Conversation
kaltepeter
force-pushed
the
feature/ng-add
branch
from
160d093 to
46498bd
Compare
src/ng-add/index.ts
Outdated
| @@ -1,9 +1,44 @@ | |||
| import { Rule, SchematicContext, Tree } from '@angular-devkit/schematics'; | |||
| import { NodePackageInstallTask } from '@angular-devkit/schematics/tasks'; | |||
|
|
|||
| const svgToTsVersion = '^5.7.0'; | |||
There was a problem hiding this comment.
TODO: Likely if there are breaking schema changes in svg-to-ts this version would matter. Right now they are aligned.
There was a problem hiding this comment.
Nice job! 💪 Currently, there are a couple of conflicts from the previous merge. If we resolve those conflicts we can merge this. As future enhancements, it would be nice that the ng-add command asks for the various properties. I am not yet sure how we can make this conditional - so for example that ng-add asks you for the conversionType. Based on that it should then aks for the correct options and then automatically configure the builder in the angular.json
|
@kaltepeter Just saw #15. Thats basically what I meant with the comment above. |
kaltepeter
force-pushed
the
feature/ng-add
branch
from
46498bd to
e83e3d3
Compare
Usage: `npm install @angular-extensions/svg-icons-builder` or `ng add @angular-extensions/svg-icons-builder` - adds `svg-to-ts` as a dev dependency
kaltepeter
force-pushed
the
feature/ng-add
branch
from
e83e3d3 to
0988b19
Compare
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Usage:
npm install @angular-extensions/svg-icons-builderorng add @angular-extensions/svg-icons-buildersvg-to-tsas a dev dependencyTested in a sample repo with
ng add,npm linkdoesn't seem to allow testing the install use case.