Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(undo-redo): prevent duplicated entries on undo stack #58

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

manfredsteyer
Copy link
Collaborator

Perform a deep comparison to prevent duplicate entries on the stack. This can, for example, happen after an undo if the component sends back the undone filter to the store.

@rainerhahnekamp
Copy link
Collaborator

@manfredsteyer do you maybe have a small snippet?

@manfredsteyer
Copy link
Collaborator Author

@rainerhahnekamp What do you mean with small snippet?

@rainerhahnekamp
Copy link
Collaborator

Just some pseudo code so that I can come up with a unit test for the

after an undo if the component sends back the undone filter to the store.

I'm not sure if I fully understand it.

@rainerhahnekamp rainerhahnekamp merged commit b4f68af into main Jun 20, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants