-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(with-storage-sync): indexeddb support #129
base: main
Are you sure you want to change the base?
Conversation
df518ef
to
df5449c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mzkmnk looks good, but I initially meant that we integrate this into the existing withStorageSync
. Like how withGlitchTracking
or withDisabledNameIndices
is done for withDevtools
.
You will very likely have to adapt the code of withStorageSync
to make this happen.
The reason for not bringing up a second storage syncer extension is that we can reuse parts of its code (like serialization)
@rainerhahnekamp |
Sure, if you have some work to delegate to me, let me know. |
@mzkmnk great work mate :) Thanks a lot. Hi @rainerhahnekamp can you please guide me how to use it and which version of the toolkit has this feature? Will it gonna be 19.0.3 ? Please let me know. Thanks in advance 🙏 |
@rainerhahnekamp |
b677206
to
03298f8
Compare
@mzkmnk big thanks for now. I will check the code asap and i do understand the potential necessity of async methods. |
2876625
to
af02b32
Compare
ea3cf84
to
8d0d308
Compare
Issue
#111
Content