Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with base repository #2

Merged
merged 980 commits into from
Oct 14, 2022
Merged
Changes from 1 commit
Commits
Show all changes
980 commits
Select commit Hold shift + click to select a range
8e1f227
Merge pull request #366 from jdmattern-noaa/persistence-mass-balance-…
rcabell Oct 16, 2019
6ccc0fb
removed persistence and reservoir_type variables from module_HYDRO_io.F
Oct 16, 2019
7e13fbf
Fix problem with gfortran-9.1.0 (#387)
afanfa Oct 16, 2019
f9de582
added capability to read reservoir_type from reservoir parameter file
Oct 16, 2019
d47d2ec
Update CMakeLists and FindNetCDF.cmake module (#388)
rcabell Oct 17, 2019
c184e4b
Merge branch 'master' into rfc_forecasts
rcabell Oct 17, 2019
857472f
Merge of upstream master.
donaldwj Oct 17, 2019
6d1845a
Merge branch 'master' of https://github.com/NCAR/wrf_hydro_nwm_public…
donaldwj Oct 17, 2019
4e56845
added dam_length to rfc_forecasts reservoirs
Oct 17, 2019
07b5a1a
Refactor 'hydro_stop' out of module_hydro_drv and place it in utils/m…
donaldwj Oct 17, 2019
a7ae8f3
Merge branch 'master' of https://github.com/NCAR/wrf_hydro_nwm_public…
Oct 17, 2019
b400753
Added changes to arc/Makefile.mpp required for build system to function.
donaldwj Oct 18, 2019
d95ecda
fixed reservoir persistence namelist parameters in orchestrator layer…
Oct 18, 2019
31f3049
changed back to original HYDRO_io and module_RT
Oct 18, 2019
cc48248
Added 'use module_hydro_stop' to files with call to call to 'hydro_st…
donaldwj Oct 18, 2019
2d26c4b
passed reservoir_parameter_file to module_HYDRO_io.F and added call t…
Oct 18, 2019
67fae0e
temporarily set reservoir_types 3 and 4 to initialize level pool
Oct 18, 2019
026bfde
fixed indentation in moduel_rfc_forecasts
Oct 21, 2019
36c8ffc
changed variable reservoir_persistence_parameter_file to reservoir_pa…
Oct 22, 2019
6041738
removed checks for setting reservoir_observation_update_time_interval…
Oct 22, 2019
d3d844f
Merge pull request #392 from jdmattern-noaa/read-reservoir-type-change
rcabell Oct 24, 2019
12cce4d
Merge branch 'master' into hydro_stop_fix
rcabell Oct 24, 2019
87c6b11
Create PULL_REQUEST_TEMPLATE.md (#380)
jmccreight Oct 24, 2019
c6f82ad
Merge branch 'master' into hydro_stop_fix
rcabell Oct 24, 2019
f715684
Remove duplicate `use` statement
rcabell Oct 24, 2019
3c1e807
adding reservoir testing files in tests directory and updated persist…
Oct 25, 2019
4accb89
Merge pull request #390 from donaldwj/hydro_stop_fix
rcabell Oct 25, 2019
18918c4
Merge branch 'master' of https://github.com/NCAR/wrf_hydro_nwm_public…
Oct 25, 2019
1b5f014
Merge branch 'master' into rfc_forecasts
rcabell Oct 25, 2019
a6b758e
removed hydro_stop.F from Reservoir directory and changed reservoir b…
Oct 25, 2019
5caf8e0
pass reservoir_type to hybrid module and added Army Corps timeslice file
Oct 25, 2019
014a95a
added unit test for ACE hybrid reservoirs and fails as expected
Oct 28, 2019
5868edd
Merge pull request #348 from jdmattern-noaa/rfc_forecasts
rcabell Oct 28, 2019
300c068
added separate timeslice reader for ACE timeslices
Oct 29, 2019
cfa2cab
Merge remote-tracking branch 'upstream/master'
kafitzgerald Oct 30, 2019
9cc65c4
merged master into branch
Oct 30, 2019
ef6dd91
fixed name differences in module_RT.F and added dam_length to rfc_for…
Oct 31, 2019
3a65883
merged rfc_forecasts_boolean_for_namelist_and_hydro_io into branch
Oct 31, 2019
f7ae108
Fix Noah standalone build (#405)
kafitzgerald Oct 31, 2019
ffc32c9
Fix CMakeLists.txt files (#408)
rcabell Oct 31, 2019
6563c84
added boolean flag for ace
Nov 1, 2019
b442d8d
Update CMakeLists.txt to include preprocessor flags (#410)
rcabell Nov 1, 2019
ab59329
changing gage id to string
Nov 4, 2019
421eb83
Merge branch 'master' of https://github.com/NCAR/wrf_hydro_nwm_public…
Nov 4, 2019
cc8aec8
added dam length to reservoir tests
Nov 4, 2019
c99fd73
Correct incorrect CMakeLists preprocessor flags (#412)
rcabell Nov 4, 2019
0a8d379
Add logic to support both KDAY and KHOUR (#415)
rcabell Nov 5, 2019
4185299
Merge branch 'master' into rfc_forecasts_boolean_for_namelist_and_hyd…
rcabell Nov 5, 2019
4746172
Merge remote-tracking branch 'upstream/master'
kafitzgerald Nov 7, 2019
fe93545
Add additional variables to AnA land outputs
kafitzgerald Oct 30, 2019
1eabcc6
A little cleanup of the long array lists for legibility. No output ch…
aubreyd Nov 1, 2019
636d732
Add QRAIN output variable to NoahMP outputs. Currently only activated…
aubreyd Nov 4, 2019
0c8bf8e
Update AnA outputs per updated request
kafitzgerald Nov 5, 2019
996fa47
Change init and valid times to include minutes
kafitzgerald Nov 6, 2019
9fb7546
Fix the rest of the output file types for hourly output metadata
kafitzgerald Nov 6, 2019
16f5b81
Merge pull request #417 from kafitzgerald/nwm_output_updates
rcabell Nov 7, 2019
ebece3e
changed persistence gage_ids to be checked as strings and separated t…
Nov 7, 2019
7d70164
changed reservoir_not_levelpool to reservoir_type_specified and updat…
Nov 7, 2019
f544cbb
Merge branch 'rfc_forecasts_boolean_for_namelist_and_hydro_io' of htt…
Nov 7, 2019
b76f806
Merge branch 'rfc_forecasts_boolean_for_namelist_and_hydro_io' into a…
Nov 7, 2019
3af5bea
cleaned up timeslice read and reservoir utility file
Nov 7, 2019
431f31d
Merge branch 'master' of https://github.com/NCAR/wrf_hydro_nwm_public…
Nov 7, 2019
1d0b66d
Merge branch 'master' into rfc_forecasts_boolean_for_namelist_and_hyd…
rcabell Nov 7, 2019
31604bd
Merge pull request #413 from jdmattern-noaa/rfc_forecasts_boolean_for…
rcabell Nov 7, 2019
37d511d
Separate NCEP_WCOSS into NCEP_WCOSS for file units and NWM_META for N…
kafitzgerald Nov 12, 2019
1203607
Merge branch 'master' into army-corps-persistence
rcabell Nov 12, 2019
e7cd010
Merge pull request #422 from jdmattern-noaa/army-corps-persistence
rcabell Nov 13, 2019
dcd2b0a
Merge remote-tracking branch 'upstream/master'
kafitzgerald Nov 21, 2019
d67f5e8
added capability to handle RFC Time Series observations and forecasts
Nov 27, 2019
42adff9
Noahmp jedi refactoring (#358)
afanfa Dec 4, 2019
f5e5948
Update CMakeLists.txt for recent code additions (#433)
rcabell Dec 5, 2019
0f1799e
Merge remote-tracking branch 'upstream/master'
kafitzgerald Dec 16, 2019
8f248ef
Add back in missing NUOPC coupling file (#435)
kafitzgerald Dec 16, 2019
b274e18
added RFC timeslice offset hours
Dec 17, 2019
1d69ebe
added checks for synthetic array
Dec 18, 2019
f29beb3
merged upstream master
Dec 18, 2019
dcafdf7
fixed compilation bugs
Dec 19, 2019
398f261
updated RFC testing files
Dec 19, 2019
21d3701
added rfc lookback hours and time series path to missing areas of orc…
Dec 19, 2019
adfd046
updated RFC Forecast unit tests and added warning output whenever a t…
Dec 25, 2019
2dedd4f
added reading of observedCounts from new time series files
Dec 27, 2019
0f32b28
updated CMake for Reservoir RFC module
Dec 31, 2019
e2a41db
moved updated current time from end of module_rfc_forecasts run funct…
Jan 14, 2020
bf02ad7
add boundary checks for discharge array in module_rfc_forecasts
Jan 14, 2020
5d28710
added check in module_rfc_forecasts run function to see if routing pe…
Jan 14, 2020
dc91ad5
updated output warnings for switching from RFC to levelpool to the RF…
Jan 14, 2020
a9b5296
removed log_warning from RFC time series reader
Jan 14, 2020
b3ef48e
added dynamic_reservoir_type to channel routing and all reservoir sub…
Jan 15, 2020
365abc4
updated unit tests
Jan 15, 2020
97de0a0
Merge remote-tracking branch 'upstream/master'
kafitzgerald Jan 20, 2020
53fc57c
updated unit tests for dynamic_reservoir_type conditions and initiali…
Jan 22, 2020
72e02b9
added dynamic reservoir type output from hybrid reservoir types
Jan 22, 2020
bc45cc9
Merge pull request #437 from jdmattern-noaa/rfc_forecasts_with_observ…
rcabell Jan 23, 2020
932cb26
Update DOI badge (#443)
kafitzgerald Jan 23, 2020
9111364
Merge branch 'master' of https://github.com/NCAR/wrf_hydro_nwm_public…
Jan 29, 2020
18d2370
added missing NetCDF close statements to RFC module files and reservo…
Jan 29, 2020
b8bcc9e
added more RFC comments
Jan 30, 2020
f5d0a13
changed namelist variable reservoir_timeslice_path to two variables r…
Jan 30, 2020
f668fd3
merged upstream master
Feb 5, 2020
855736f
Add support for writing reservoir_type into LAKEOUT output files
rcabell Feb 4, 2020
b1a7d11
added dynamic_reservoir_type to levelpool call in module_rfc_forecasts
Feb 5, 2020
0195f1e
Merge branch 'output-dynamic-reservoir-type' of https://github.com/jd…
Feb 5, 2020
3f36ec1
Merge pull request #439 from jdmattern-noaa/output-dynamic-reservoir-…
rcabell Feb 5, 2020
d2b90d7
Merge branch 'master' into rfc_forecasts_updates
rcabell Feb 5, 2020
8fe224a
Merge branch 'master' of https://github.com/NCAR/wrf_hydro_nwm_public…
Feb 6, 2020
e7e73b8
updated reservoir tests with dynamic_reservoir_type for RFC reservoir…
Feb 6, 2020
cb54ea5
updated logic in RFC module to output correct dynamic reservoir type
Feb 6, 2020
7772f63
added RFC Forecasts check and unit tests for any time series value ex…
Feb 6, 2020
539d4ec
added reservoir unit test for RFC Forecast Extended AnA
Feb 6, 2020
ad605fc
Merge branch 'rfc_forecasts_updates' of https://github.com/jdmattern-…
Feb 6, 2020
5020a4d
Merge pull request #446 from jdmattern-noaa/rfc_forecasts_updates
rcabell Feb 7, 2020
8bcc040
Merge remote-tracking branch 'upstream/master'
kafitzgerald Feb 11, 2020
29c4196
Update to nf90create and remove large file ifdefs
kafitzgerald Nov 13, 2019
06bc397
changed peak flow comment cfs to cms
Feb 12, 2020
80395eb
Merge pull request #451 from jdmattern-noaa/peak-flow-cfs-comment-change
kafitzgerald Feb 12, 2020
5e94a74
Merge branch 'master' into io_update
rcabell Feb 12, 2020
38b8e94
updated reservoir module warning and error messages
Feb 13, 2020
bdbb499
updated reservoir error handling
Feb 14, 2020
c8cd9dd
Merge remote-tracking branch 'upstream/master'
kafitzgerald Feb 17, 2020
6c9d0ad
update water masking in NWM IO
kafitzgerald Feb 17, 2020
9722511
added usace reservoir overflow and missing timeslice unit tests back in
Feb 19, 2020
e9bb403
updated Persistence_Level_Pool_Hybrid_Module_README.md
Feb 19, 2020
9a8f5ac
Change scale/offset integers to kind=4 to match netCDF file type
rcabell Feb 20, 2020
ba933b8
Merge pull request #456 from kafitzgerald/bugfix_water_class
rcabell Feb 20, 2020
7e63555
Merge branch 'master' into io_update
rcabell Feb 20, 2020
3eba170
Merge branch 'master' into netcdf-fix
rcabell Feb 20, 2020
e95acfb
Merge pull request #459 from rcabell/netcdf-fix
rcabell Feb 20, 2020
aee4a7a
Merge branch 'master' into io_update
rcabell Feb 20, 2020
e37d328
Merge pull request #449 from kafitzgerald/io_update
rcabell Feb 20, 2020
9d5e874
Merge branch 'master' into reservoir-warning-statement-updates
rcabell Feb 20, 2020
9d4b52e
Add parallel sync calls for final_reservoir_type (#462)
rcabell Feb 21, 2020
c413d77
split up long statements into multiple lines
Feb 21, 2020
1fa1b7c
Merge branch 'reservoir-warning-statement-updates' of https://github.…
Feb 21, 2020
e653d8a
Merge branch 'master' into reservoir-warning-statement-updates
rcabell Feb 21, 2020
40b4538
Merge pull request #454 from jdmattern-noaa/reservoir-warning-stateme…
rcabell Feb 26, 2020
05030b8
changed RFCTimeSlice to RFCTimeSeries for netcdf name for RFC reservoirs
Feb 26, 2020
d0926ed
changed RFC reservoir testing netcdf file names
Feb 26, 2020
dd33ad9
Merge pull request #465 from jdmattern-noaa/rfc-time-series-file-name…
rcabell Feb 26, 2020
e7a6cef
Merge remote-tracking branch 'upstream/master'
kafitzgerald Mar 3, 2020
0849973
update template namelists to include water management updates and oth…
kafitzgerald Mar 4, 2020
f8fa370
Modify hydro.namelist template per comments from NOAA devs
kafitzgerald Mar 5, 2020
b9cded9
updated default reservoir lookback hour variables and reservoir READMEs
Mar 5, 2020
7557f01
Merge pull request #467 from kafitzgerald/update_hydronamelist_template
rcabell Mar 5, 2020
6c5dc8d
Merge branch 'master' into reservoir-readme-updates
rcabell Mar 5, 2020
e0f6567
Merge pull request #469 from jdmattern-noaa/reservoir-readme-updates
rcabell Mar 5, 2020
1ad4e62
Merge remote-tracking branch 'upstream/master'
kafitzgerald Mar 6, 2020
f3e128a
update config_meta
kafitzgerald Mar 6, 2020
0917513
remove NWM templates to put elsewhere
kafitzgerald Mar 6, 2020
7bd8164
Update metadata logging to use correct file suffixes
kafitzgerald Mar 6, 2020
5913c15
Merge pull request #470 from kafitzgerald/update_file_metadata
rcabell Mar 6, 2020
df5810a
Update .version
rcabell Mar 10, 2020
a326f0d
Update .nwm_version
rcabell Mar 10, 2020
c0ff58c
Remove command to copy wcoss tables and update compile script logic t…
kafitzgerald Mar 11, 2020
44b5982
Minor hardening of nudging timeslice path to force include "/" at the…
jmccreight Mar 10, 2020
37b8f95
Minor hardening of reservoir timeslice path to force include "/" at t…
rcabell Mar 10, 2020
35a413d
Minor hardening of RFC time series path to force include "/" at the end
rcabell Mar 11, 2020
230f230
Testing output change (#473)
jmccreight Mar 12, 2020
5896584
Add assimilated_value and assimilated_source_file to channel routing,…
Apr 7, 2020
9619856
Add MPI parallelization and LAKEOUT writing of reservoir_assimilated_…
Apr 10, 2020
3f65e38
Merge pull request #476 from jdmattern-noaa/reservoir-assimilated-data
rcabell Apr 21, 2020
fb23205
Changes to medium range RTOUT output frequency and valid times
kafitzgerald Apr 21, 2020
865dcb0
Merge pull request #478 from kafitzgerald/medium_range_io_update
rcabell Apr 22, 2020
45b32b5
Add global attribute TITLE to all output files
kafitzgerald Apr 29, 2020
557548f
Lake Out File Comment Additions (#486)
jdmattern Apr 30, 2020
7b05c66
Bump version numbers for alpha3
rcabell Apr 30, 2020
e6ff71e
Remove reservoir_assimilated_source_file variable write
kafitzgerald May 11, 2020
2bd2ca2
Merge pull request #493 from kafitzgerald/v5.2.0
kafitzgerald May 11, 2020
a2fe830
bump version number for alpha4
kafitzgerald May 11, 2020
c25160c
Revert "Remove reservoir_assimilated_source_file variable write"
kafitzgerald May 27, 2020
076d5a5
increment code version number
kafitzgerald May 27, 2020
bd67194
Revise long name for zwattablrt
kafitzgerald Jun 11, 2020
7c1b129
increment version number
kafitzgerald Jun 11, 2020
d5bbeb5
Merge pull request #500 from kafitzgerald/minor_metadata_update
kafitzgerald Jun 11, 2020
7488f77
Performance improvements in initialization routines using Fortran has…
afanfa Sep 10, 2020
5a83241
Update defaults for channel params in gridded (#503)
laurareads Oct 5, 2020
a148074
Fix NUOPC cap surface head hookup by pointing to overland control dat…
danrosen25 May 19, 2019
2db4120
Clean up WRF-Hydro NUOPC cap output and diagnostic utilities. Add imp…
danrosen25 Aug 24, 2019
20e3330
Fix VERSION file creation in NUOPC_cpl.
danrosen25 Aug 24, 2019
22b8a26
Replace MPI_COMM_WORLD with HYDRO_COMM_WORLD. This allows hydro to ru…
danrosen25 Oct 7, 2019
ff6031a
Add multiple instance option to WRF-Hydro NUOPC cap. If multi_instanc…
danrosen25 Oct 8, 2019
8c4bef7
Add NUOPC cap read and write restart state feature.
danrosen25 Mar 13, 2020
e05337b
Update NUOPC cap to support change from nlst_rt to nlst.
danrosen25 Jul 16, 2020
09f6454
Merge pull request #518 from NESII/feature/NUOPC
rcabell Oct 7, 2020
51e7df3
Add new feature contributor checklist to contributor guidelines.
aubreyd Oct 7, 2020
3bef8c7
Update .version to v5.2.0-beta1
rcabell Oct 5, 2020
686daf3
Add ISLAKE to relevant NoahMP code (#464)
kafitzgerald Oct 26, 2020
1c5708c
Remove unneeded call to MPP_LAND_INIT from module_HYDRO_drv
kafitzgerald Jan 24, 2020
853a0ff
Move LSM grid dimension read up and add dimensions as vars to MPP_LAN…
kafitzgerald Jan 24, 2020
8214640
Add arguments to MPP_LAND_INIT and logic regarding LSM grid to getNX_…
kafitzgerald Jan 24, 2020
3c0575b
Remove no longer relevant namelist check for reach lakes
kafitzgerald Oct 26, 2020
2b714f6
deactivated mpi calls and writing of reservoir_assimilated_source_fil…
Oct 28, 2020
d9940ef
Add missing crop and soil NoahMP namelist options (#489)
prasanthvkrishna Oct 29, 2020
e0c1494
Add -std=legacy to macros to support gnu >= 10.0.1
rcabell Oct 26, 2020
4d0c8ad
Update .version
rcabell Oct 29, 2020
742eebf
Make arguments optional for MPP_LAND_INIT so that we don't break non-…
kafitzgerald Nov 19, 2020
4b5e8e5
Chan loss merge2.1 (#516)
TimLahmers Dec 17, 2020
d090fa7
Reduce fill value digits for 3 LDAS output vars to deal with nodata v…
aubreyd Dec 29, 2020
f48fba1
Add in new snow-related vars to retro outputs per OWP request.
aubreyd Dec 21, 2020
c13cefb
Add in SFCRNOFF output flag that is tied to overland runoff switch, s…
aubreyd Dec 31, 2020
2b0adbf
Update .version file to v5.2.0; remove .nwm_version
rcabell Jan 29, 2021
7cc628c
1. Add support for calling CMake build from another project.
danrosen25 Feb 4, 2021
6d7ad76
Correct a few Fortran standards-compliance issues (#540)
rcabell Feb 23, 2021
1f40fc2
Fix and enhance support for Cray Fortran compilers
rcabell Feb 12, 2021
d1c8e6b
Move WPC and AREAC initialization into the loop
jameshalgren Feb 24, 2021
14b9d0b
Add time dimension to CHANOBS (#438)
jmccreight Apr 9, 2021
8e57277
Prevent double-create of CHANOBS file (#544)
rcabell Apr 11, 2021
7cf193b
Bump py from 1.8.0 to 1.10.0 in /tests/local (#547)
dependabot[bot] Apr 21, 2021
df784c8
Update NUOPC Cap and CMake build (#546)
danrosen25 Apr 22, 2021
8a61c8f
Add Xinanjiang Surface Runoff Scheme (#559)
prasanthvkrishna Jun 9, 2021
7bd095f
Bump urllib3 from 1.24.3 to 1.26.5 in /tests/local (#561)
dependabot[bot] Jun 23, 2021
d87e523
Text only updates to contributing guidelines, PR template, and news (…
kafitzgerald Jun 30, 2021
3cb66da
Create test-pr.yml, rename .travis.yml
rcabell Jun 30, 2021
385b797
Fix GitHub Actions workflow bugs
rcabell Jul 8, 2021
469297d
Change snow NIR albedo to use correct BATS NIR parameter. No answer c…
aubreyd Jul 21, 2021
57bce6f
Fix CMake when NWM_META=1
danrosen25 Jul 23, 2021
0d119f7
MPI_Abort for clean return to shell (#564)
jmccreight Aug 6, 2021
35d42d5
Allow other tests to proceed if one fails
rscabell Sep 24, 2021
0916fd9
Update reach / lake IDs to 64-bit (#582)
rcabell Sep 28, 2021
9a45591
Remove Desk dependency from tests
dependabot[bot] Dec 15, 2021
a717529
NCO Bugzilla [Bug 1164] (#574)
zhengtaocui Jan 14, 2022
8122fb2
Improving performance of nudging routines (#480)
afanfa Jan 15, 2022
047d9b2
Update to support PGI Fortran 20.4 compiler (#502)
rcabell Jan 19, 2022
1c8c372
Correct mismatch in minimum slope limit. Setting both back to 1e-5. (…
aubreyd Feb 7, 2022
00eed48
Channel NaN fixes for Muskingum-Cunge (#599)
aubreyd Feb 7, 2022
459c86e
Update WRF coupler to recent MPP_LAND_INIT changes (#602)
rcabell Feb 9, 2022
2dbe34f
Update NUOPC cap exchange fields (#600)
danrosen25 Feb 11, 2022
0a5a94c
Solution to fix the request to download google drive file
scrasmussen Mar 9, 2022
616d1b5
Move max SWE limit to a parameter in MPTABLE.
aubreyd Nov 10, 2020
758ea38
Fix for energy NAs over large snowpacks due to very small numbers bei…
aubreyd Nov 10, 2020
b757c38
Add priority snow parameters to 2d parameter file and add new scamax …
aubreyd Mar 17, 2022
4626525
Initial commit of adding nexp free parameter to hydro2dtbl. Only setu…
aubreyd Aug 24, 2020
4095f91
Fix issue with default nexp value when no parameter found in input file.
aubreyd Aug 25, 2021
0306cd1
Fix parallel issue with nexp being overwritten on non-io cores.
aubreyd Feb 24, 2022
e5bff60
New channel option to bypass actual channel routing solver and just p…
aubreyd Mar 21, 2022
6f314bc
New impervious runoff adjustment options (#608)
aubreyd Mar 21, 2022
c20829c
Add Crocus snowpack/glacier model to WRF-Hydro (#607)
scrasmussen Mar 21, 2022
0d5e8d3
bugfix: added Crocus to CMake files
scrasmussen Mar 23, 2022
33a8507
Alaska Glacier Dammed Lake Release RFC Assimilation (#581)
jdmattern Apr 6, 2022
e6d52f0
Balance and ensure boundaries of RFC Forecasts Reservoirs water eleva…
Jun 4, 2020
ddf7c1a
Added reservoir unit test for long-range AnA RFC-Forcast offset
Jun 5, 2020
0c61d32
Fix bug in forcing LAI read dims. Minor updates to VEGFRA for consist…
aubreyd Nov 18, 2021
5cfc4d2
Move overland roughness assignment out of time cycling disaggregation…
aubreyd May 4, 2022
ad6a2de
Add negative smc check and fix to SSTEP solver to prevent NaNs from X…
aubreyd Aug 9, 2022
8f0706d
bugfix issue 650: initialize stepwtd to one to avoid SIGFPE from usin…
scrasmussen Aug 14, 2022
dcd5cda
Bugfix Issue 648: when crocus_opt is off, ZP_SNOWDZ(1,1) is allocated…
scrasmussen Sep 2, 2022
c547959
Transition a few remaining 'include mpif.h' statements to 'use mpi'.
scrasmussen Sep 2, 2022
8adbcee
Bump numpy from 1.17.1 to 1.22.0 in /tests/local (#642)
dependabot[bot] Sep 2, 2022
57dce00
New Feature: trunk/NDHMS has been moved to src/ directory to follow m…
scrasmussen Jun 3, 2022
4c32e10
bugfix: fixes issue #653 so Cray compiler now builds. Removes comma a…
scrasmussen Oct 3, 2022
9ade8fa
fixed NCO Bugzilla 1156, [Bug 1156] New: Missing debug, install and t…
zhengtaocui Jul 22, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added dam_length to rfc_forecasts reservoirs
John David Mattern committed Oct 17, 2019
commit 4e568452157ae216c06939fb588605d50edc8540
Original file line number Diff line number Diff line change
@@ -42,7 +42,7 @@ module module_rfc_forecasts
! RFC Forecasts Constructor
subroutine rfc_forecasts_init(this, water_elevation, &
lake_area, weir_elevation, weir_coeffecient, &
weir_length, orifice_elevation, orifice_coefficient, &
weir_length, dam_length, orifice_elevation, orifice_coefficient, &
orifice_area, lake_max_water_elevation, initial_fractional_depth, &
lake_number)
implicit none
@@ -52,6 +52,7 @@ subroutine rfc_forecasts_init(this, water_elevation, &
real, intent(in) :: weir_elevation ! bottom of weir elevation (meters AMSL)
real, intent(in) :: weir_coeffecient ! weir coefficient
real, intent(in) :: weir_length ! weir length (meters)
real, intent(in) :: dam_length ! dam length (meters)
real, intent(in) :: orifice_elevation ! orifice elevation (meters AMSL)
real, intent(in) :: orifice_coefficient ! orifice coefficient
real, intent(in) :: orifice_area ! orifice area (meters^2)
Loading