Migrate samples off ALooper_pollAll. #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only one left is the vulkan sample. That one crashed when I did the trivial thing, so I'm leaving it for last. There's a fair amount of absurd stuff left around the code I touched. Some samples have a lot of code dedicated to managing sensors that then do nothing with the sensors, some display a static image but have a render "loop", all of these have a nearly identical main loop but don't share any code, etc. I'll be back.
The problem was the missing `canRender` check around the render call, causing the app to being rendering before the window was ready if it got that far before processing all the pending events.
DanAlbert
changed the title
jreck
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a fair amount of absurd stuff left around the code I touched. Some samples have a lot of code dedicated to managing sensors that then do nothing with the sensors, some display a static image but have a render "loop", all of these have a nearly identical main loop but don't share any code, etc. I'll be back.