Remove odd engine_draw_frame call patterns. #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enh-google
approved these changes
May 1, 2024
Moving this to a centrally controlled location so it's easier to migrate to choreographer. Also turn the stupid int into a bool.
It looks like whoever wrote this just kept adding draw calls until it worked. For some reason if I removed the call from `APP_CMD_INIT_WINDOW` (which really shouldn't have needed to render), or added an `if (!animating)` early exist to engine_draw_frame, it would prevent the app from *ever* rendering. I never figured out why, but in any case the most important call is the one that was missing: the one in `APP_CMD_GAINED_FOCUS`. That's why the rendering wouldn't start until you tapped the screen. I added that and now all the calls that appear superfluous in fact are.
DanAlbert
force-pushed
the
fix-draw-behavior
branch
from
33bd363 to
5b0f25e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like whoever wrote this just kept adding draw calls until it worked. For some reason if I removed the call from
APP_CMD_INIT_WINDOW(which really shouldn't have needed to render), or added anif (!animating)early exist to engine_draw_frame, it would prevent the app from ever rendering. I never figured out why, but in any case the most important call is the one that was missing: the one inAPP_CMD_GAINED_FOCUS. That's why the rendering wouldn't start until you tapped the screen. I added that and now all the calls that appear superfluous in fact are.Depends on #1005.