updated branch with hooks of pack screens #399
Conversation
|
Your Render PR Server URL is https://packrat-dev-pr-399.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-ckadcfugtj9c738tibg0. |
client/app/_layout.js
Outdated
|
|
||
| export default function HomeLayout() { | ||
| const queryClient = new QueryClient() |
There was a problem hiding this comment.
we should move this to to its own TrpcQueryProvider context just for cleaner code
|
Your Render PR Server at https://packrat-dev-pr-399.onrender.com is now live! View it on your dashboard at https://dashboard.render.com/web/srv-ckadcfugtj9c738tibg0. |
client/hooks/packs.js
Outdated
|
|
||
| export const useAddNewPack = () => { | ||
| // console.log(obj); | ||
| const mutation = queryTrpc.addPack.useMutation(); |
There was a problem hiding this comment.
is this standard naming practice for react query custom hooks? genuine question i'm not sure
There was a problem hiding this comment.
We should at the very least be destructuring isLoading and error from the react query responses. To make it more like the redux store
client/hooks/packs.js
Outdated
| let isLoading = true; | ||
| switch (feedType) { | ||
| case 'public': | ||
| const publicPacks = queryTrpc.getPublicPacks.useQuery({ queryBy:queryString ? queryString: 'Favorite' }, { |
There was a problem hiding this comment.
We should at the very least be destructuring isLoading and error from the react query responses. To make it more like the redux store
client/components/pack/AddPack.js
Outdated
| @@ -28,7 +28,7 @@ export const AddPack = () => { | |||
| const error = useSelector((state) => state.packs.error); | |||
|
|
|||
| const isError = error !== null; | |||
|
|
|||
| const { mutation } = useAddNewPack() | |||
|
Uncaught Error |
Trpc react query
updated the search into packs and get single trip and fetch global items
client/hooks/weather.js
Outdated
| refetchOnWindowFocus: false, | ||
| keepPreviousData: true, | ||
| }); | ||
| const isOwner = data && user && data.owner_id === user._id; |
There was a problem hiding this comment.
user is undefined here, maybe we should use our matches current user hook for this ?
…PackRat into trpc-react-query
No description provided.