Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add check on favorites to show only zero or positive number #329

Open
wants to merge 1 commit into
base: andrew_testing
Choose a base branch
from
Open

add check on favorites to show only zero or positive number #329

wants to merge 1 commit into from

Conversation

umair90rb
Copy link
Collaborator

No description provided.

@render
Copy link

render bot commented Aug 28, 2023

Your Render PR Server URL is https://packrat-dev-pr-329.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cjm4982nip6c73ef0bqg.

@andrew-bierman
Copy link
Owner

We should fix the underlying issue that is allowing favorites to go negative though, somewhere our logic is flawed.

@umair90rb
Copy link
Collaborator Author

noted, I am on it

@andrew-bierman
Copy link
Owner

Make this a virtual property on backend that reflects favorited count

andrew-bierman
andrew-bierman requested changes Aug 30, 2023
View reviewed changes
Copy link
Owner

@andrew-bierman andrew-bierman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix this on the backend

@umair90rb
Copy link
Collaborator Author

yeah got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-bierman andrew-bierman andrew-bierman requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@umair90rb @andrew-bierman