-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Landing Page Layour Design Changed #1160
Conversation
❌ Tests failed for this pull request. 😞 |
Deploying packrat with Cloudflare Pages
|
Tauri build completed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the update looks great and this is ready to be merged. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The landing page looks great, but the theme change button isn't working. Also, I think it would be better if we could make the logo more visible.
@MuhammadHassan03 pls resolve conflicts then this should be good |
Android APK build completed! |
@andrew-bierman conflicts resolved :) |
iOS IPA build completed! |
@Isthisanmol pls take quick look and make sure style changes work with your theming logic |
@MuhammadHassan03 I suggest using colors from the theme instead of hardcoding them, so they can dynamically adjust according to the theme. |
Yeah I forget to replace. Thanks for pointing out |
…-bierman/PackRat into feat/tamagui_landing_page
b41c5a4
to
64a0beb
Compare
@Isthisanmol pls double check and see if this breaks any of the stuff you have been working on recently |
@MuhammadHassan03 It looks great on web but on native it was giving error regarding zindex |
I don't have access to native 😕 will fix it after setup of native on my machine |
…-bierman/PackRat into feat/tamagui_landing_page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MuhammadHassan03 Here are the issues I encountered
…feat/tamagui_landing_page
@JewelTee @MuhammadHassan03 we don't need landing page on native app, let's show the current version of starting screen instead |
Sure |
…dding conditional logic to load different styles based on platform."
Now we show the old version of the intro screen on native, I'm merging this to development branch @JewelTee can you please test it there |
No description provided.