Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing Page Layour Design Changed #1160

Merged
merged 38 commits into from
Oct 9, 2024

Conversation

MuhammadHassan03
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Aug 7, 2024

❌ Tests failed for this pull request. 😞

View Test Workflow

Copy link

cloudflare-workers-and-pages bot commented Aug 7, 2024

Deploying packrat with  Cloudflare Pages  Cloudflare Pages

Latest commit: ab5cc60
Status: ✅  Deploy successful!
Preview URL: https://de86abe1.packrat.pages.dev
Branch Preview URL: https://feat-tamagui-landing-page.packrat.pages.dev

View logs

Copy link

github-actions bot commented Aug 7, 2024

Tauri build completed!
You can download the build artifacts from the following link:
https://github.com/andrew-bierman/PackRat/actions/runs/10595077737#artifacts

Copy link
Collaborator

@EngrAJ8888 EngrAJ8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the update looks great and this is ready to be merged. Thanks!

Copy link
Collaborator

@Isthisanmol Isthisanmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The landing page looks great, but the theme change button isn't working. Also, I think it would be better if we could make the logo more visible.

@andrew-bierman
Copy link
Owner

@MuhammadHassan03 pls resolve conflicts then this should be good

Copy link

github-actions bot commented Aug 19, 2024

Android APK build completed!
You can download the Android APK from the following link:
https://github.com/andrew-bierman/PackRat/actions/runs/11254848318#artifacts

@MuhammadHassan03
Copy link
Collaborator Author

@MuhammadHassan03 pls resolve conflicts then this should be good

@andrew-bierman conflicts resolved :)

Copy link

github-actions bot commented Aug 19, 2024

iOS IPA build completed!
You can download the iOS IPA from the following link:
https://github.com/andrew-bierman/PackRat/actions/runs/11254848318#artifacts

@andrew-bierman
Copy link
Owner

@Isthisanmol pls take quick look and make sure style changes work with your theming logic

@Isthisanmol
Copy link
Collaborator

@MuhammadHassan03 I suggest using colors from the theme instead of hardcoding them, so they can dynamically adjust according to the theme.

@MuhammadHassan03
Copy link
Collaborator Author

@MuhammadHassan03 I suggest using colors from the theme instead of hardcoding them, so they can dynamically adjust according to the theme.

Yeah I forget to replace. Thanks for pointing out

@MuhammadHassan03 MuhammadHassan03 force-pushed the feat/tamagui_landing_page branch from b41c5a4 to 64a0beb Compare September 7, 2024 12:43
@andrew-bierman
Copy link
Owner

@Isthisanmol pls double check and see if this breaks any of the stuff you have been working on recently

@Isthisanmol
Copy link
Collaborator

@MuhammadHassan03 It looks great on web but on native it was giving error regarding zindex

@MuhammadHassan03
Copy link
Collaborator Author

@MuhammadHassan03 It looks great on web but on native it was giving error regarding zindex

I don't have access to native 😕 will fix it after setup of native on my machine

@MuhammadHassan03 MuhammadHassan03 changed the base branch from andrew_testing to development October 8, 2024 13:48
Copy link
Collaborator

@JewelTee JewelTee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MuhammadHassan03 Here are the issues I encountered

  • The Text was cut
    image

  • Arrows not working
    image

  • Can we adjust the size of the FAQ's ?

image

@taronaleksanian
Copy link
Collaborator

@JewelTee @MuhammadHassan03 we don't need landing page on native app, let's show the current version of starting screen instead

@MuhammadHassan03
Copy link
Collaborator Author

@JewelTee @MuhammadHassan03 we don't need landing page on native app, let's show the current version of starting screen instead

Sure

@taronaleksanian
Copy link
Collaborator

Now we show the old version of the intro screen on native, I'm merging this to development branch @JewelTee can you please test it there

@taronaleksanian taronaleksanian merged commit 99064ba into development Oct 9, 2024
13 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants