LPD-3453 No reason is given when it's impossible to continue the checkout #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelevigilante
force-pushed
the
LPD-3453
branch
from
eafeb11 to
1d46650
Compare
andrea-ale-sbarra
requested changes
Mar 28, 2024
Comment on lines
118
to
120
| List<CommerceOrderItem> commerceOrderItems = | ||
| commerceOrder.getCommerceOrderItems(); | ||
|
|
There was a problem hiding this comment.
you don't need to declare this variable
| List<CommerceOrderValidatorResult> | ||
| commerceOrderValidatorResults = | ||
| _commerceOrderValidatorRegistry.validate( | ||
| renderRequest.getLocale(), commerceOrder); | ||
|
|
||
| for (CommerceOrderItem commerceOrderItem : commerceOrderItems) { |
There was a problem hiding this comment.
Suggested change
| for (CommerceOrderItem commerceOrderItem : commerceOrderItems) { | |
| for (CommerceOrderItem commerceOrderItem : commerceOrder.getCommerceOrderItems()) { |
michelevigilante
force-pushed
the
LPD-3453
branch
from
1d46650 to
7225c3e
Compare
michelevigilante
force-pushed
the
LPD-3453
branch
from
7225c3e to
2346e87
Compare
Date processor should not be editable at any point
…is editable is only meant to be mapped
…search engine, instead of 400 individual requests https://liferay.atlassian.net/browse/LPD-25878
…continue the checkout
michelevigilante
force-pushed
the
LPD-3453
branch
from
2346e87 to
f0be7d4
Compare
michelevigilante
force-pushed
the
LPD-3453
branch
from
f0be7d4 to
ba1fece
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-3453