Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat -- table owner categories #2260

Merged
merged 10 commits into from
Sep 25, 2024
Prev Previous commit
Next Next commit
Add other_key_values field to User interface
Signed-off-by: Ben Dye <bdye@lyft.com>
B-T-D committed Aug 28, 2024
commit 3d5142cd39bb744736161aca90555dce83a50b4e
Original file line number Diff line number Diff line change
@@ -6,6 +6,7 @@ export interface User {
email: string;
profile_url: string;
user_id: string;
other_key_values?: Record<string, string>;
kristenarmes marked this conversation as resolved.
Show resolved Hide resolved
}

// Not a good name, not sure if we can consolidate yet

Unchanged files with check annotations Beta

const { large, isBookmarked } = this.props;
return (
<div

Check warning on line 72 in frontend/amundsen_application/static/js/components/Bookmark/BookmarkIcon/index.tsx

GitHub Actions / test-unit-frontend (12.x)

Visible, non-interactive elements with click handlers must have at least one keyboard listener

Check warning on line 72 in frontend/amundsen_application/static/js/components/Bookmark/BookmarkIcon/index.tsx

GitHub Actions / test-unit-frontend (12.x)

Static HTML elements with event handlers require a role
className={'bookmark-icon ' + (large ? 'bookmark-large' : '')}
onClick={this.handleClick}
>
return (
<section className="editable-section">
<label className="editable-section-label">

Check warning on line 143 in frontend/amundsen_application/static/js/components/EditableSection/index.tsx

GitHub Actions / test-unit-frontend (12.x)

A form label must be associated with a control
<div
className="editable-section-label-wrapper"
onClick={!readOnly ? this.preventDefault : undefined}
} = this.props;
if (prevProps.value !== propValue) {
this.setState({ value: propValue });

Check warning on line 84 in frontend/amundsen_application/static/js/components/EditableText/index.tsx

GitHub Actions / test-unit-frontend (12.x)

Do not use setState in componentDidUpdate
} else if (isEditing && !prevProps.isEditing) {
const textArea = this.textAreaRef.current;
!isDisabled
) {
// disable the component if a refresh is needed
this.setState({ isDisabled: true });

Check warning on line 102 in frontend/amundsen_application/static/js/components/EditableText/index.tsx

GitHub Actions / test-unit-frontend (12.x)

Do not use setState in componentDidUpdate
}
}
/>
)}
{isEditable && (
<button

Check warning on line 68 in frontend/amundsen_application/static/js/components/EntityCard/EntityCardSection/index.tsx

GitHub Actions / test-unit-frontend (12.x)

A control must be associated with a text label
type="button"
className={`btn ${activeButtonClass}`}
onClick={this.toggleEditMode}
<FlashMessage
message="Flash message text that can be short"
onClose={() => {
alert('message closed!');

Check warning on line 19 in frontend/amundsen_application/static/js/components/FlashMessage/flashMessage.story.tsx

GitHub Actions / test-unit-frontend (12.x)

Unexpected alert
}}
/>
</StorySection>
message="Flash message text that can be short"
iconClass={ImageIconType.ALERT}
onClose={() => {
alert('message closed!');

Check warning on line 28 in frontend/amundsen_application/static/js/components/FlashMessage/flashMessage.story.tsx

GitHub Actions / test-unit-frontend (12.x)

Unexpected alert
}}
/>
</StorySection>
beforeAll(() => {
const setupResult = setup();
props = setupResult.props;

Check warning on line 36 in frontend/amundsen_application/static/js/components/Inputs/CheckBoxItem/index.spec.tsx

GitHub Actions / test-unit-frontend (12.x)

Use object destructuring
wrapper = setupResult.wrapper;

Check warning on line 37 in frontend/amundsen_application/static/js/components/Inputs/CheckBoxItem/index.spec.tsx

GitHub Actions / test-unit-frontend (12.x)

Use object destructuring
});
it('renders itself with correct class', () => {